From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Axel Lin <axel.lin@ingics.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails
Date: Fri, 12 Apr 2013 13:51:22 +0200 [thread overview]
Message-ID: <1413655.hhUbBAKNUi@vostro.rjw.lan> (raw)
In-Reply-To: <1365746058.4025.1.camel@phoenix>
On Friday, April 12, 2013 01:54:18 PM Axel Lin wrote:
> We need to call mutex_unlock() in the error path.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
All three patches applied to linux-pm.git/linux-next.
Exynos maintainers, if you have any objections, please holler.
Thanks,
Rafael
> ---
> drivers/devfreq/exynos4_bus.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
> index 1deee09..54b9615 100644
> --- a/drivers/devfreq/exynos4_bus.c
> +++ b/drivers/devfreq/exynos4_bus.c
> @@ -974,7 +974,8 @@ static int exynos4_busfreq_pm_notifier_event(struct notifier_block *this,
> rcu_read_unlock();
> dev_err(data->dev, "%s: unable to find a min freq\n",
> __func__);
> - return PTR_ERR(opp);
> + err = PTR_ERR(opp);
> + goto unlock;
> }
> new_oppinfo.rate = opp_get_freq(opp);
> new_oppinfo.volt = opp_get_voltage(opp);
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-04-12 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 5:54 [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails Axel Lin
2013-04-12 5:55 ` [RESEND][PATCH 2/3] PM / devfreq: exynos4_bus: Constify clock divider table Axel Lin
2013-04-12 5:56 ` [RESEND][PATCH 3/3] PM / devfreq: exynos4_bus: Fix table entry size for exynos4x12_clkdiv_dmc1 Axel Lin
2013-04-12 11:51 ` Rafael J. Wysocki [this message]
2013-04-12 12:11 ` [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails myungjoo.ham
2013-04-12 23:20 ` Rafael J. Wysocki
2013-04-13 1:40 ` Axel Lin
2013-04-17 16:39 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2013-04-12 11:52 함명주
2013-04-12 12:04 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413655.hhUbBAKNUi@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=axel.lin@ingics.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).