From: Lucas Stach <l.stach@pengutronix.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [RESEND 2] cpufreq: dt: disable unsupported OPPs
Date: Thu, 23 Oct 2014 16:10:48 +0200 [thread overview]
Message-ID: <1414073448.2764.1.camel@pengutronix.de> (raw)
In-Reply-To: <CAMuHMdV2gPOZoV62rSNjpD=dJ43EE+s0wtRW4ncLWU-J-eHLDg@mail.gmail.com>
Hi Geert,
Am Donnerstag, den 23.10.2014, 11:19 +0200 schrieb Geert Uytterhoeven:
> Hi Rafael, Lucas,
>
> On Tue, Oct 21, 2014 at 4:19 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Thursday, October 16, 2014 12:08:20 PM Lucas Stach wrote:
> >> If the regulator connected to the CPU voltage plane doesn't
> >> support an OPP specified voltage with the acceptable tolerance
> >> it's better to just disable the OPP instead of constantly
> >> failing the voltage scaling later on.
> >>
> >> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > Applied, thanks!
>
> This commit
> (http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=d7bbd4cd0359d781b67c9e621d4bbfd1bb2f3783)
> causes a boot regression on r8a7791/koelsch. It hangs after:
>
> TCP: cubic registered
> Initializing XFRM netlink socket
> NET: Registered protocol family 17
> NET: Registered protocol family 15
> ata1: link resume succeeded after 1 retries
> ata1: SATA link down (SStatus 0 SControl 300)
> random: nonblocking pool is initialized
>
> With more debugging, it seems to end up in an infinite loop
> calling runtime_{suspend,resume}():
>
> cpufreq-dt cpufreq-dt: pm_clk_notify() 4
> i2c-sh_mobile e60b0000.i2c: pm_clk_resume()
> MSTP i2c6 ON
> i2c-sh_mobile e60b0000.i2c: pm_clk_suspend()
> MSTP i2c6 OFF
> i2c-sh_mobile e60b0000.i2c: pm_clk_resume()
> MSTP i2c6 ON
> i2c-sh_mobile e60b0000.i2c: pm_clk_suspend()
> MSTP i2c6 OFF
> i2c-sh_mobile e60b0000.i2c: pm_clk_resume()
> MSTP i2c6 ON
> i2c-sh_mobile e60b0000.i2c: pm_clk_suspend()
> MSTP i2c6 OFF
> i2c-sh_mobile e60b0000.i2c: pm_clk_resume()
> MSTP i2c6 ON
> i2c-sh_mobile e60b0000.i2c: pm_clk_suspend()
> MSTP i2c6 OFF
> i2c-sh_mobile e60b0000.i2c: pm_clk_resume()
> ...
>
> Reverting this commit fixes the issue, and makes the boot continue with:
>
> cpufreq: __cpufreq_add_dev: CPU0: Running at unlisted freq: 1300000 KHz
> cpufreq: __cpufreq_add_dev: CPU0: Unlisted initial frequency
> changed to: 1312500 KHz
> cpu cpu1: failed to get cpu-2 clock: 1
> cpufreq_dt: cpufreq_init: Failed to allocate resources: -2
>
Urgh, thanks for the report. Am I right that for koelsch you do
reference a regulator supply for the cpu, but don't actually have a
driver for it, so a dummy regulator gets plugged in there?
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2014-10-23 14:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 15:29 [PATCH resend] cpufreq: dt: disable unsupported OPPs Lucas Stach
2014-09-30 19:53 ` Rafael J. Wysocki
2014-10-01 3:29 ` Viresh Kumar
2014-10-01 20:39 ` Rafael J. Wysocki
2014-10-02 5:24 ` Viresh Kumar
2014-10-02 11:57 ` Lucas Stach
2014-10-02 17:33 ` Rafael J. Wysocki
2014-10-08 22:36 ` Rafael J. Wysocki
2014-10-09 3:43 ` Viresh Kumar
2014-10-12 20:27 ` Rafael J. Wysocki
2014-10-16 10:08 ` [RESEND 2] " Lucas Stach
2014-10-21 14:19 ` Rafael J. Wysocki
2014-10-23 9:19 ` Geert Uytterhoeven
2014-10-23 14:10 ` Lucas Stach [this message]
2014-10-23 14:43 ` Geert Uytterhoeven
2014-10-23 15:13 ` Lucas Stach
2014-10-23 21:26 ` Rafael J. Wysocki
2014-10-24 0:26 ` Khiem Nguyen
2014-10-24 10:19 ` Lucas Stach
2014-10-24 12:30 ` Geert Uytterhoeven
2014-10-24 12:39 ` Lucas Stach
2014-10-24 13:01 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414073448.2764.1.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=geert@linux-m68k.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).