From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Subject: Re: [RESEND 2] cpufreq: dt: disable unsupported OPPs Date: Thu, 23 Oct 2014 16:10:48 +0200 Message-ID: <1414073448.2764.1.camel@pengutronix.de> References: <48734362.lRa73hezrZ@vostro.rjw.lan> <1413454100-23009-1-git-send-email-l.stach@pengutronix.de> <8590662.lsNXszcTd0@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Geert Uytterhoeven Cc: "Rafael J. Wysocki" , Viresh Kumar , Linux PM list , Linux-sh list List-Id: linux-pm@vger.kernel.org Hi Geert, Am Donnerstag, den 23.10.2014, 11:19 +0200 schrieb Geert Uytterhoeven: > Hi Rafael, Lucas, > > On Tue, Oct 21, 2014 at 4:19 PM, Rafael J. Wysocki wrote: > > On Thursday, October 16, 2014 12:08:20 PM Lucas Stach wrote: > >> If the regulator connected to the CPU voltage plane doesn't > >> support an OPP specified voltage with the acceptable tolerance > >> it's better to just disable the OPP instead of constantly > >> failing the voltage scaling later on. > >> > >> Signed-off-by: Lucas Stach > >> Acked-by: Viresh Kumar > > > > Applied, thanks! > > This commit > (http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=d7bbd4cd0359d781b67c9e621d4bbfd1bb2f3783) > causes a boot regression on r8a7791/koelsch. It hangs after: > > TCP: cubic registered > Initializing XFRM netlink socket > NET: Registered protocol family 17 > NET: Registered protocol family 15 > ata1: link resume succeeded after 1 retries > ata1: SATA link down (SStatus 0 SControl 300) > random: nonblocking pool is initialized > > With more debugging, it seems to end up in an infinite loop > calling runtime_{suspend,resume}(): > > cpufreq-dt cpufreq-dt: pm_clk_notify() 4 > i2c-sh_mobile e60b0000.i2c: pm_clk_resume() > MSTP i2c6 ON > i2c-sh_mobile e60b0000.i2c: pm_clk_suspend() > MSTP i2c6 OFF > i2c-sh_mobile e60b0000.i2c: pm_clk_resume() > MSTP i2c6 ON > i2c-sh_mobile e60b0000.i2c: pm_clk_suspend() > MSTP i2c6 OFF > i2c-sh_mobile e60b0000.i2c: pm_clk_resume() > MSTP i2c6 ON > i2c-sh_mobile e60b0000.i2c: pm_clk_suspend() > MSTP i2c6 OFF > i2c-sh_mobile e60b0000.i2c: pm_clk_resume() > MSTP i2c6 ON > i2c-sh_mobile e60b0000.i2c: pm_clk_suspend() > MSTP i2c6 OFF > i2c-sh_mobile e60b0000.i2c: pm_clk_resume() > ... > > Reverting this commit fixes the issue, and makes the boot continue with: > > cpufreq: __cpufreq_add_dev: CPU0: Running at unlisted freq: 1300000 KHz > cpufreq: __cpufreq_add_dev: CPU0: Unlisted initial frequency > changed to: 1312500 KHz > cpu cpu1: failed to get cpu-2 clock: 1 > cpufreq_dt: cpufreq_init: Failed to allocate resources: -2 > Urgh, thanks for the report. Am I right that for koelsch you do reference a regulator supply for the cpu, but don't actually have a driver for it, so a dummy regulator gets plugged in there? Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ |