From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Subject: Re: [RESEND 2] cpufreq: dt: disable unsupported OPPs Date: Fri, 24 Oct 2014 12:19:49 +0200 Message-ID: <1414145989.6267.3.camel@pengutronix.de> References: <48734362.lRa73hezrZ@vostro.rjw.lan> <1413454100-23009-1-git-send-email-l.stach@pengutronix.de> <8590662.lsNXszcTd0@vostro.rjw.lan> <1414073448.2764.1.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:58424 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751391AbaJXKTw (ORCPT ); Fri, 24 Oct 2014 06:19:52 -0400 In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Geert Uytterhoeven Cc: "Rafael J. Wysocki" , Viresh Kumar , Linux PM list , Linux-sh list Geert, Am Donnerstag, den 23.10.2014, 16:43 +0200 schrieb Geert Uytterhoeven: > Hi Lucas, > > On Thu, Oct 23, 2014 at 4:10 PM, Lucas Stach wrote: > > Am Donnerstag, den 23.10.2014, 11:19 +0200 schrieb Geert Uytterhoeven: > >> On Tue, Oct 21, 2014 at 4:19 PM, Rafael J. Wysocki wrote: > >> > On Thursday, October 16, 2014 12:08:20 PM Lucas Stach wrote: > >> >> If the regulator connected to the CPU voltage plane doesn't > >> >> support an OPP specified voltage with the acceptable tolerance > >> >> it's better to just disable the OPP instead of constantly > >> >> failing the voltage scaling later on. > >> >> > >> >> Signed-off-by: Lucas Stach > >> >> Acked-by: Viresh Kumar > >> > > >> > Applied, thanks! > >> > >> This commit > >> (http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=d7bbd4cd0359d781b67c9e621d4bbfd1bb2f3783) > >> causes a boot regression on r8a7791/koelsch. It hangs after: > >> > >> TCP: cubic registered > >> Initializing XFRM netlink socket > >> NET: Registered protocol family 17 > >> NET: Registered protocol family 15 > >> ata1: link resume succeeded after 1 retries > >> ata1: SATA link down (SStatus 0 SControl 300) > >> random: nonblocking pool is initialized > > >> Reverting this commit fixes the issue, and makes the boot continue with: > >> > >> cpufreq: __cpufreq_add_dev: CPU0: Running at unlisted freq: 1300000 KHz > >> cpufreq: __cpufreq_add_dev: CPU0: Unlisted initial frequency > >> changed to: 1312500 KHz > >> cpu cpu1: failed to get cpu-2 clock: 1 > >> cpufreq_dt: cpufreq_init: Failed to allocate resources: -2 > >> > > I thought a bit more about about this to make sure this isn't a fault on my side, but can't seem to make any sense out of this. Can you please print out the value of opp_freq in each iteration of the while loop and also the return value of regulator_is_supported_voltage()? This would help me a lot to understand what's happening here. Thanks, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ |