From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Linus Walleij <linus.walleij@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Lv Zheng <lv.zheng@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
Anton Vorontsov <anton@enomsg.org>, Pavel Machek <pavel@ucw.cz>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 7/7] mfd: ab8500: Decrement the power supply's device reference counter
Date: Tue, 04 Nov 2014 08:50:09 +0100 [thread overview]
Message-ID: <1415087409.2389.2.camel@AMDC1943> (raw)
In-Reply-To: <20141103180059.GW12011@x1>
On pon, 2014-11-03 at 18:00 +0000, Lee Jones wrote:
> On Mon, 03 Nov 2014, Lee Jones wrote:
>
> > On Tue, 14 Oct 2014, Krzysztof Kozlowski wrote:
> >
> > > Use power_supply_put() to decrement the power supply's device reference
> > > counter.
> > >
> > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > > ---
> > > drivers/mfd/ab8500-sysctrl.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> >
> > Applied, thanks.
>
> Whoops, to hasty there -- unapplied.
>
> What's going on with this set?
The set should be pulled at once (everything depends on 1st patch).
It is still waiting for reviews. I'll resend soon.
Best regards,
Krzysztof
>
> > > diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c
> > > index 93b2d2c32ca3..d05a5719cfc4 100644
> > > --- a/drivers/mfd/ab8500-sysctrl.c
> > > +++ b/drivers/mfd/ab8500-sysctrl.c
> > > @@ -51,6 +51,7 @@ static void ab8500_power_off(void)
> > >
> > > ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_ONLINE,
> > > &val);
> > > + power_supply_put(psy);
> > >
> > > if (!ret && val.intval) {
> > > charger_present = true;
> > > @@ -73,6 +74,7 @@ static void ab8500_power_off(void)
> > > pss[i]);
> > > machine_restart("charging");
> > > }
> > > + power_supply_put(psy);
> > > }
> > >
> > > shutdown:
> >
>
next prev parent reply other threads:[~2014-11-04 7:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 12:35 [PATCH 0/7] power_supply: Decrement the device reference counter Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 1/7] power_supply: Add power_supply_put for decrementing " Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 2/7] power: charger-manager: Decrement the power supply's " Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 3/7] x86/olpc/xo1/sci: Use newly added power_supply_put API Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 4/7] x86/olpc/xo15/sci: " Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 5/7] power: 88pm860x_charger: Decrement the power supply's device reference counter Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 6/7] power: bq2415x_charger: " Krzysztof Kozlowski
2014-10-14 12:35 ` [PATCH 7/7] mfd: ab8500: " Krzysztof Kozlowski
2014-10-28 10:00 ` Linus Walleij
2014-11-03 17:59 ` Lee Jones
2014-11-03 18:00 ` Lee Jones
2014-11-04 7:50 ` Krzysztof Kozlowski [this message]
2014-10-15 12:18 ` [PATCH 0/7] power_supply: Decrement the " Pavel Machek
2014-10-15 12:52 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415087409.2389.2.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=anton@enomsg.org \
--cc=b.zolnierkie@samsung.com \
--cc=bhelgaas@google.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=kyungmin.park@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=m.szyprowski@samsung.com \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=sameo@linux.intel.com \
--cc=sre@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).