From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Alan Stern <stern@rowland.harvard.edu>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Jonathan Corbet <corbet@lwn.net>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-pm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>,
Michal Simek <michal.simek@xilinx.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v8 3/5] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM
Date: Tue, 04 Nov 2014 08:59:29 +0100 [thread overview]
Message-ID: <1415087969.2389.10.camel@AMDC1943> (raw)
In-Reply-To: <20141103154433.GC4042@n2100.arm.linux.org.uk>
On pon, 2014-11-03 at 15:44 +0000, Russell King - ARM Linux wrote:
> On Mon, Nov 03, 2014 at 10:41:02AM -0500, Alan Stern wrote:
> > Bear in mind, however, that once the irq_safe flag has been set, the
> > runtime PM core offers no way to turn it off again.
>
> Ah, I thought it did permit it to change both ways. In that case, we
> don't need to validate that it doesn't change state on each call, and
> we can just get away with checking its value.
It cannot be unset but still it could be *set* during runtime (not only
in probe). However that shouldn't happen between suspend-resume calls,
so the solution of undoing suspend's work seems fine.
I'll send a new patch doing this way. Without the wrapper.
Best regards,
Krzysztof
next prev parent reply other threads:[~2014-11-04 7:59 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 9:04 [PATCH v8 0/5] amba/dma: pl330: add Power Management support Krzysztof Kozlowski
2014-10-20 9:04 ` [PATCH v8 1/5] PM / Runtime: Add getter for querying the IRQ safe option Krzysztof Kozlowski
2014-10-31 9:14 ` Krzysztof Kozlowski
2014-10-31 9:29 ` Ulf Hansson
2014-10-31 9:33 ` Russell King - ARM Linux
2014-10-31 9:54 ` Ulf Hansson
2014-10-31 9:33 ` Krzysztof Kozlowski
2014-10-31 14:22 ` Pavel Machek
2014-10-31 14:40 ` Krzysztof Kozlowski
2014-11-01 0:29 ` Laurent Pinchart
2014-11-03 9:36 ` Krzysztof Kozlowski
2014-11-03 16:27 ` Vinod Koul
2014-11-03 16:59 ` Laurent Pinchart
2014-11-05 14:09 ` Vinod Koul
2014-11-03 17:04 ` Russell King - ARM Linux
2014-11-05 14:04 ` Vinod Koul
2014-11-05 14:54 ` Laurent Pinchart
2014-10-31 23:11 ` Rafael J. Wysocki
2014-10-31 23:04 ` Russell King - ARM Linux
2014-11-01 0:42 ` Rafael J. Wysocki
2014-11-03 8:51 ` Krzysztof Kozlowski
2014-10-20 9:04 ` [PATCH v8 2/5] amba: Add helpers for (un)preparing AMBA clock Krzysztof Kozlowski
2014-10-21 8:05 ` Ulf Hansson
2014-10-20 9:04 ` [PATCH v8 3/5] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM Krzysztof Kozlowski
2014-11-01 0:45 ` Rafael J. Wysocki
2014-11-01 0:55 ` Russell King - ARM Linux
2014-11-01 1:01 ` Russell King - ARM Linux
2014-11-03 8:36 ` Krzysztof Kozlowski
2014-11-03 10:04 ` Russell King - ARM Linux
2014-11-03 15:41 ` Alan Stern
2014-11-03 15:44 ` Russell King - ARM Linux
2014-11-04 7:59 ` Krzysztof Kozlowski [this message]
2014-11-04 1:57 ` Rafael J. Wysocki
2014-11-04 8:01 ` Krzysztof Kozlowski
2014-11-04 9:11 ` Ulf Hansson
2014-11-04 13:59 ` Rafael J. Wysocki
2014-11-04 16:19 ` Ulf Hansson
2014-11-04 16:42 ` Alan Stern
2014-11-03 17:17 ` Kevin Hilman
2014-10-20 9:04 ` [PATCH v8 4/5] dma: pl330: add Power Management support Krzysztof Kozlowski
2014-10-20 9:04 ` [PATCH v8 5/5] amba: Remove unused amba_pclk_enable/disable macros Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415087969.2389.10.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=lars@metafoo.de \
--cc=len.brown@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=michal.simek@xilinx.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).