[PATCH 00/28] remove .owner for most platform_drivers: the missing bits

[PATCH 00/28] remove .owner for most platform_drivers: the missing bits

[Wolfram Sang]

Generated with coccinelle. The big cleanup was pulled in this merge window.
This series catches the bits fallen through. The patches shall go in via the
subsystem trees. If possible for 3.19 to increase consistency I'd say, but you
decide, of course.

cocci-file used:

@match1@
declarer name module_platform_driver;
declarer name module_platform_driver_probe;
declarer name for_each_node_by_type;
identifier __driver;
@@
(
	module_platform_driver(__driver);
|
	module_platform_driver_probe(__driver, ...);
)

@fix1 depends on match1@
identifier match1.__driver;
@@
	static struct platform_driver __driver = {
		.driver = {
-			.owner = THIS_MODULE,
		}
	};

@match2@
identifier __driver;
@@
(
	platform_driver_register(&__driver)
|
	platform_driver_probe(&__driver, ...)
|
	platform_create_bundle(&__driver, ...)
)

@fix2 depends on match2@
identifier match2.__driver;
@@
	static struct platform_driver __driver = {
		.driver = {
-			.owner = THIS_MODULE,
		}
	};

Thanks again to Julia Lawall for support. And hey, we fixed a coccinelle bug on
the way :)


Wolfram Sang (28):
  ARM: mach-exynos: drop owner assignment from platform_drivers
  mips: lantiq: xway: drop owner assignment from platform_drivers
  mips: pci: drop owner assignment from platform_drivers
  char: ipmi: drop owner assignment from platform_drivers
  cpufreq: drop owner assignment from platform_drivers
  dma: drop owner assignment from platform_drivers
  gpio: drop owner assignment from platform_drivers
  gpu: drm: rockchip: drop owner assignment from platform_drivers
  iommu: drop owner assignment from platform_drivers
  net: ethernet: stmicro: stmmac: drop owner assignment from
    platform_drivers
  net: wireless: ath: ath5k: drop owner assignment from platform_drivers
  of: drop owner assignment from platform_drivers
  pci: host: drop owner assignment from platform_drivers
  phy: drop owner assignment from platform_drivers
  pinctrl: intel: drop owner assignment from platform_drivers
  rtc: drop owner assignment from platform_drivers
  scsi: drop owner assignment from platform_drivers
  thermal: drop owner assignment from platform_drivers
  thermal: int340x_thermal: drop owner assignment from platform_drivers
  tty: serial: 8250: drop owner assignment from platform_drivers
  usb: gadget: udc: bdc: drop owner assignment from platform_drivers
  watchdog: drop owner assignment from platform_drivers
  ASoC: intel: drop owner assignment from platform_drivers
  ASoC: intel: sst: drop owner assignment from platform_drivers
  ASoC: omap: drop owner assignment from platform_drivers
  ASoC: pxa: drop owner assignment from platform_drivers
  ASoC: samsung: drop owner assignment from platform_drivers
  macintosh: drop owner assignment from platform_drivers

 arch/arm/mach-exynos/pmu.c                            | 1 -
 arch/mips/lantiq/xway/vmmc.c                          | 1 -
 arch/mips/pci/pci-ar2315.c                            | 1 -
 arch/mips/pci/pci-rt2880.c                            | 1 -
 drivers/char/ipmi/ipmi_powernv.c                      | 1 -
 drivers/cpufreq/ls1x-cpufreq.c                        | 1 -
 drivers/dma/at_xdmac.c                                | 1 -
 drivers/gpio/gpio-vf610.c                             | 1 -
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c           | 1 -
 drivers/iommu/rockchip-iommu.c                        | 1 -
 drivers/macintosh/windfarm_pm112.c                    | 1 -
 drivers/macintosh/windfarm_pm72.c                     | 1 -
 drivers/macintosh/windfarm_rm31.c                     | 1 -
 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 -
 drivers/net/wireless/ath/ath5k/ahb.c                  | 1 -
 drivers/of/unittest.c                                 | 1 -
 drivers/pci/host/pci-layerscape.c                     | 1 -
 drivers/phy/phy-armada375-usb2.c                      | 1 -
 drivers/phy/phy-berlin-usb.c                          | 1 -
 drivers/phy/phy-miphy28lp.c                           | 1 -
 drivers/pinctrl/intel/pinctrl-cherryview.c            | 1 -
 drivers/rtc/rtc-opal.c                                | 1 -
 drivers/scsi/atari_scsi.c                             | 1 -
 drivers/scsi/mac_scsi.c                               | 1 -
 drivers/scsi/sun3_scsi.c                              | 1 -
 drivers/thermal/int340x_thermal/int3400_thermal.c     | 1 -
 drivers/thermal/int340x_thermal/int3402_thermal.c     | 1 -
 drivers/thermal/rockchip_thermal.c                    | 1 -
 drivers/tty/serial/8250/8250_omap.c                   | 1 -
 drivers/usb/gadget/udc/bdc/bdc_core.c                 | 1 -
 drivers/watchdog/cadence_wdt.c                        | 1 -
 drivers/watchdog/meson_wdt.c                          | 1 -
 sound/soc/intel/bytcr_dpcm_rt5640.c                   | 1 -
 sound/soc/intel/cht_bsw_rt5672.c                      | 1 -
 sound/soc/intel/sst/sst_acpi.c                        | 1 -
 sound/soc/omap/omap-hdmi-audio.c                      | 1 -
 sound/soc/pxa/spitz.c                                 | 1 -
 sound/soc/samsung/arndale_rt5631.c                    | 1 -
 38 files changed, 38 deletions(-)

-- 
2.1.3

[PATCH 05/28] cpufreq: drop owner assignment from platform_drivers

[Wolfram Sang]

This platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Generated with coccinelle. SmPL file is in the introductory msg. The big
cleanup was pulled in this merge window. This series catches the bits fallen
through. The patches shall go in via the subsystem trees.

 drivers/cpufreq/ls1x-cpufreq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/cpufreq/ls1x-cpufreq.c b/drivers/cpufreq/ls1x-cpufreq.c
index 25fbd6a1374f..f0913eee2f50 100644
--- a/drivers/cpufreq/ls1x-cpufreq.c
+++ b/drivers/cpufreq/ls1x-cpufreq.c
@@ -210,7 +210,6 @@ out:
 static struct platform_driver ls1x_cpufreq_platdrv = {
 	.driver = {
 		.name	= "ls1x-cpufreq",
-		.owner	= THIS_MODULE,
 	},
 	.probe		= ls1x_cpufreq_probe,
 	.remove		= ls1x_cpufreq_remove,
-- 
2.1.3

Re: [PATCH 05/28] cpufreq: drop owner assignment from platform_drivers

[Viresh Kumar]

On 22 December 2014 at 02:44, Wolfram Sang <wsa@the-dreams.de> wrote:
> This platform_driver does not need to set an owner, it will be populated by the
> driver core.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> Generated with coccinelle. SmPL file is in the introductory msg. The big
> cleanup was pulled in this merge window. This series catches the bits fallen
> through. The patches shall go in via the subsystem trees.
>
>  drivers/cpufreq/ls1x-cpufreq.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/ls1x-cpufreq.c b/drivers/cpufreq/ls1x-cpufreq.c
> index 25fbd6a1374f..f0913eee2f50 100644
> --- a/drivers/cpufreq/ls1x-cpufreq.c
> +++ b/drivers/cpufreq/ls1x-cpufreq.c
> @@ -210,7 +210,6 @@ out:
>  static struct platform_driver ls1x_cpufreq_platdrv = {
>         .driver = {
>                 .name   = "ls1x-cpufreq",
> -               .owner  = THIS_MODULE,
>         },
>         .probe          = ls1x_cpufreq_probe,
>         .remove         = ls1x_cpufreq_remove,

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Re: [PATCH 05/28] cpufreq: drop owner assignment from platform_drivers

[Rafael J. Wysocki]

On Monday, December 22, 2014 07:14:56 AM Viresh Kumar wrote:
> On 22 December 2014 at 02:44, Wolfram Sang <wsa@the-dreams.de> wrote:
> > This platform_driver does not need to set an owner, it will be populated by the
> > driver core.
> >
> > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > ---
> > Generated with coccinelle. SmPL file is in the introductory msg. The big
> > cleanup was pulled in this merge window. This series catches the bits fallen
> > through. The patches shall go in via the subsystem trees.
> >
> >  drivers/cpufreq/ls1x-cpufreq.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/ls1x-cpufreq.c b/drivers/cpufreq/ls1x-cpufreq.c
> > index 25fbd6a1374f..f0913eee2f50 100644
> > --- a/drivers/cpufreq/ls1x-cpufreq.c
> > +++ b/drivers/cpufreq/ls1x-cpufreq.c
> > @@ -210,7 +210,6 @@ out:
> >  static struct platform_driver ls1x_cpufreq_platdrv = {
> >         .driver = {
> >                 .name   = "ls1x-cpufreq",
> > -               .owner  = THIS_MODULE,
> >         },
> >         .probe          = ls1x_cpufreq_probe,
> >         .remove         = ls1x_cpufreq_remove,
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> --

OK

Wolfram, please feel free to push this through whatever tree you think is
appropriate.


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH 05/28] cpufreq: drop owner assignment from platform_drivers

[Wolfram Sang]

On Mon, Dec 22, 2014 at 11:39:32PM +0100, Rafael J. Wysocki wrote:
> On Monday, December 22, 2014 07:14:56 AM Viresh Kumar wrote:
> > On 22 December 2014 at 02:44, Wolfram Sang <wsa@the-dreams.de> wrote:
> > > This platform_driver does not need to set an owner, it will be populated by the
> > > driver core.
> > >
> > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > > ---
> > > Generated with coccinelle. SmPL file is in the introductory msg. The big
> > > cleanup was pulled in this merge window. This series catches the bits fallen
> > > through. The patches shall go in via the subsystem trees.
> > >
> > >  drivers/cpufreq/ls1x-cpufreq.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/cpufreq/ls1x-cpufreq.c b/drivers/cpufreq/ls1x-cpufreq.c
> > > index 25fbd6a1374f..f0913eee2f50 100644
> > > --- a/drivers/cpufreq/ls1x-cpufreq.c
> > > +++ b/drivers/cpufreq/ls1x-cpufreq.c
> > > @@ -210,7 +210,6 @@ out:
> > >  static struct platform_driver ls1x_cpufreq_platdrv = {
> > >         .driver = {
> > >                 .name   = "ls1x-cpufreq",
> > > -               .owner  = THIS_MODULE,
> > >         },
> > >         .probe          = ls1x_cpufreq_probe,
> > >         .remove         = ls1x_cpufreq_remove,
> > 
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> > --
> 
> OK
> 
> Wolfram, please feel free to push this through whatever tree you think is
> appropriate.

I'd prefer if you take it. However, I'll send all leftover ones to Greg,
so you can decide.

Re: [PATCH 05/28] cpufreq: drop owner assignment from platform_drivers

[Rafael J. Wysocki]

On Wednesday, December 31, 2014 11:23:26 AM Wolfram Sang wrote:
> On Mon, Dec 22, 2014 at 11:39:32PM +0100, Rafael J. Wysocki wrote:
> > On Monday, December 22, 2014 07:14:56 AM Viresh Kumar wrote:
> > > On 22 December 2014 at 02:44, Wolfram Sang <wsa@the-dreams.de> wrote:
> > > > This platform_driver does not need to set an owner, it will be populated by the
> > > > driver core.
> > > >
> > > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > > > ---
> > > > Generated with coccinelle. SmPL file is in the introductory msg. The big
> > > > cleanup was pulled in this merge window. This series catches the bits fallen
> > > > through. The patches shall go in via the subsystem trees.
> > > >
> > > >  drivers/cpufreq/ls1x-cpufreq.c | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/drivers/cpufreq/ls1x-cpufreq.c b/drivers/cpufreq/ls1x-cpufreq.c
> > > > index 25fbd6a1374f..f0913eee2f50 100644
> > > > --- a/drivers/cpufreq/ls1x-cpufreq.c
> > > > +++ b/drivers/cpufreq/ls1x-cpufreq.c
> > > > @@ -210,7 +210,6 @@ out:
> > > >  static struct platform_driver ls1x_cpufreq_platdrv = {
> > > >         .driver = {
> > > >                 .name   = "ls1x-cpufreq",
> > > > -               .owner  = THIS_MODULE,
> > > >         },
> > > >         .probe          = ls1x_cpufreq_probe,
> > > >         .remove         = ls1x_cpufreq_remove,
> > > 
> > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> > > --
> > 
> > OK
> > 
> > Wolfram, please feel free to push this through whatever tree you think is
> > appropriate.
> 
> I'd prefer if you take it. However, I'll send all leftover ones to Greg,
> so you can decide.

I've queued it up for 3.20, thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

[PATCH 18/28] thermal: drop owner assignment from platform_drivers

[Wolfram Sang]

This platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Generated with coccinelle. SmPL file is in the introductory msg. The big
cleanup was pulled in this merge window. This series catches the bits fallen
through. The patches shall go in via the subsystem trees.

 drivers/thermal/rockchip_thermal.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
index 1bcddfc60e91..9c6ce548e363 100644
--- a/drivers/thermal/rockchip_thermal.c
+++ b/drivers/thermal/rockchip_thermal.c
@@ -677,7 +677,6 @@ static SIMPLE_DEV_PM_OPS(rockchip_thermal_pm_ops,
 static struct platform_driver rockchip_thermal_driver = {
 	.driver = {
 		.name = "rockchip-thermal",
-		.owner = THIS_MODULE,
 		.pm = &rockchip_thermal_pm_ops,
 		.of_match_table = of_rockchip_thermal_match,
 	},
-- 
2.1.3

Re: [PATCH 18/28] thermal: drop owner assignment from platform_drivers

[Zhang Rui]

On Sun, 2014-12-21 at 22:14 +0100, Wolfram Sang wrote:
> This platform_driver does not need to set an owner, it will be populated by the
> driver core.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

both PATCH 18/28 and 19/28 look good to me. applied.

thanks,
rui
> ---
> Generated with coccinelle. SmPL file is in the introductory msg. The big
> cleanup was pulled in this merge window. This series catches the bits fallen
> through. The patches shall go in via the subsystem trees.
> 
>  drivers/thermal/rockchip_thermal.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
> index 1bcddfc60e91..9c6ce548e363 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -677,7 +677,6 @@ static SIMPLE_DEV_PM_OPS(rockchip_thermal_pm_ops,
>  static struct platform_driver rockchip_thermal_driver = {
>  	.driver = {
>  		.name = "rockchip-thermal",
> -		.owner = THIS_MODULE,
>  		.pm = &rockchip_thermal_pm_ops,
>  		.of_match_table = of_rockchip_thermal_match,
>  	},

[PATCH 19/28] thermal: int340x_thermal: drop owner assignment from platform_drivers

[Wolfram Sang]

This platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Generated with coccinelle. SmPL file is in the introductory msg. The big
cleanup was pulled in this merge window. This series catches the bits fallen
through. The patches shall go in via the subsystem trees.

 drivers/thermal/int340x_thermal/int3400_thermal.c | 1 -
 drivers/thermal/int340x_thermal/int3402_thermal.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/thermal/int340x_thermal/int3400_thermal.c b/drivers/thermal/int340x_thermal/int3400_thermal.c
index dcb306ea14a4..65a98a97df07 100644
--- a/drivers/thermal/int340x_thermal/int3400_thermal.c
+++ b/drivers/thermal/int340x_thermal/int3400_thermal.c
@@ -335,7 +335,6 @@ static struct platform_driver int3400_thermal_driver = {
 	.remove = int3400_thermal_remove,
 	.driver = {
 		   .name = "int3400 thermal",
-		   .owner = THIS_MODULE,
 		   .acpi_match_table = ACPI_PTR(int3400_thermal_match),
 		   },
 };
diff --git a/drivers/thermal/int340x_thermal/int3402_thermal.c b/drivers/thermal/int340x_thermal/int3402_thermal.c
index a5d08c14ba24..c5cbc3af3a05 100644
--- a/drivers/thermal/int340x_thermal/int3402_thermal.c
+++ b/drivers/thermal/int340x_thermal/int3402_thermal.c
@@ -231,7 +231,6 @@ static struct platform_driver int3402_thermal_driver = {
 	.remove = int3402_thermal_remove,
 	.driver = {
 		   .name = "int3402 thermal",
-		   .owner = THIS_MODULE,
 		   .acpi_match_table = int3402_thermal_match,
 		   },
 };
-- 
2.1.3