From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 1/1] drivers/base: Remove unnecessary OOM message Date: Fri, 06 Feb 2015 13:04:30 -0800 Message-ID: <1423256670.4752.16.camel@perches.com> References: <20150206153912.GA8486@sloth> <20150206205852.GA14126@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150206205852.GA14126@amd> Sender: linux-kernel-owner@vger.kernel.org To: Pavel Machek Cc: Quentin Lambert , Ming Lei , Greg Kroah-Hartman , "Rafael J. Wysocki" , Len Brown , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org List-Id: linux-pm@vger.kernel.org On Fri, 2015-02-06 at 21:58 +0100, Pavel Machek wrote: > On Fri 2015-02-06 16:39:12, Quentin Lambert wrote: > > This patch fix checkpatch warnings concerning the possible > > duplication of an "out of memory" message. > > So, instead of nice and readable "not enough memory for clock..." we > get OOM, stackdump, and backtrace...? Not sure it is improvement. All allocs without __GFP_NOWARN already gets an OOM and stackdump. These are just unnecessary.