linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Punit Agrawal <punit.agrawal@arm.com>
To: edubezval@gmail.com
Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org,
	Punit Agrawal <punit.agrawal@arm.com>
Subject: [PATCH] thermal: Default OF created trip points to writable
Date: Tue, 10 Feb 2015 18:21:46 +0000	[thread overview]
Message-ID: <1423592506-20620-1-git-send-email-punit.agrawal@arm.com> (raw)

When registering a thermal zone from device tree, default the trip
points to writable. By default, only the root user can change these.

This allows the trip points to be tweaked after the system has
booted.

Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
---
Hi Eduardo,

We've been using this patch internally and haven't run into any
 issues. Without these changes there is no way to change trip points
 from a running system.

Comments welcome.

Cheers,
Punit

 drivers/thermal/of-thermal.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
index 668fb1b..b7ad5c0 100644
--- a/drivers/thermal/of-thermal.c
+++ b/drivers/thermal/of-thermal.c
@@ -865,6 +865,7 @@ int __init of_parse_thermal_zones(void)
 	for_each_child_of_node(np, child) {
 		struct thermal_zone_device *zone;
 		struct thermal_zone_params *tzp;
+		int i, mask = 0;
 
 		/* Check whether child is enabled or not */
 		if (!of_device_is_available(child))
@@ -891,8 +892,11 @@ int __init of_parse_thermal_zones(void)
 		/* No hwmon because there might be hwmon drivers registering */
 		tzp->no_hwmon = true;
 
+		for (i = 0; i < tz->ntrips; i++)
+			mask |= 1 << i;
+
 		zone = thermal_zone_device_register(child->name, tz->ntrips,
-						    0, tz,
+						    mask, tz,
 						    ops, tzp,
 						    tz->passive_delay,
 						    tz->polling_delay);
-- 
2.1.4


             reply	other threads:[~2015-02-10 18:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10 18:21 Punit Agrawal [this message]
2015-02-16 15:14 ` [PATCH] thermal: Default OF created trip points to writable Eduardo Valentin
2015-02-17 11:12   ` Punit Agrawal
2015-02-24 19:52     ` Eduardo Valentin
2015-02-25 12:25       ` Punit Agrawal
2015-02-25 18:47         ` Eduardo Valentin
2015-02-26 10:16           ` Punit Agrawal
2015-02-25 16:24       ` Srinivas Pandruvada
2015-02-25 18:52         ` Eduardo Valentin
2015-02-26  2:36           ` Srinivas Pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423592506-20620-1-git-send-email-punit.agrawal@arm.com \
    --to=punit.agrawal@arm.com \
    --cc=edubezval@gmail.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).