Re: [PATCH] thermal: Default OF created trip points to writable

[Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>]

Hi Eduardo,
On Wed, 2015-02-25 at 14:52 -0400, Eduardo Valentin wrote:
> Srinivas,
> 
> > > 
> > > I am copying Srinivas here too. Srinivas, do you think that option (1)
> > > above will break things in userspace on your side?
> > I am not sure distros like ubuntu starts Linux Thermal Daemon on ARM
> > systems. This has option to take over thermal control from kernel by
> > changing governor to user space. I take writable trips as a way to get
> > threshold temp notification for users space governor by setting offset
> > from a read only passive/active/critical trips. This way we get notified
> > before, to monitor an do proactive control. For example if there is a
> > critical trip at X, take action at X-a to avoid shutdown.
> 
> Let me ask differently. If the trip points are read only, would the
> daemon still work?
Yes.

Thanks,
Srinivas
> 
> If not, the change needs to make writable in x86 builds, right?
> 
> BR,
> 
> > Thanks,
> > Srinivas 
> > > 
> > > > 
> > > > Cheers,
> > > > Punit
> > > > 
> > > > >
> > > > >
> > > > > BR,
> > > > >
> > > > > Eduardo Valentin
> > > > >
> > > > >> 
> > > > >> Comments welcome.
> > > > >> 
> > > > >> Cheers,
> > > > >> Punit
> > > > >> 
> > > > >>  drivers/thermal/of-thermal.c | 6 +++++-
> > > > >>  1 file changed, 5 insertions(+), 1 deletion(-)
> > > > >> 
> > > > >> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> > > > >> index 668fb1b..b7ad5c0 100644
> > > > >> --- a/drivers/thermal/of-thermal.c
> > > > >> +++ b/drivers/thermal/of-thermal.c
> > > > >> @@ -865,6 +865,7 @@ int __init of_parse_thermal_zones(void)
> > > > >>  	for_each_child_of_node(np, child) {
> > > > >>  		struct thermal_zone_device *zone;
> > > > >>  		struct thermal_zone_params *tzp;
> > > > >> +		int i, mask = 0;
> > > > >>  
> > > > >>  		/* Check whether child is enabled or not */
> > > > >>  		if (!of_device_is_available(child))
> > > > >> @@ -891,8 +892,11 @@ int __init of_parse_thermal_zones(void)
> > > > >>  		/* No hwmon because there might be hwmon drivers registering */
> > > > >>  		tzp->no_hwmon = true;
> > > > >>  
> > > > >> +		for (i = 0; i < tz->ntrips; i++)
> > > > >> +			mask |= 1 << i;
> > > > >> +
> > > > >>  		zone = thermal_zone_device_register(child->name, tz->ntrips,
> > > > >> -						    0, tz,
> > > > >> +						    mask, tz,
> > > > >>  						    ops, tzp,
> > > > >>  						    tz->passive_delay,
> > > > >>  						    tz->polling_delay);
> > > > >> -- 
> > > > >> 2.1.4
> > > > >> 
> > 
> >