From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valentin Rothberg Subject: [PATCH] power/smb347-charger.c: set IRQF_ONESHOT flag to ensure IRQ request Date: Mon, 2 Mar 2015 15:32:48 +0100 Message-ID: <1425306768-16140-1-git-send-email-Valentin.Rothberg@lip6.fr> Return-path: Sender: linux-kernel-owner@vger.kernel.org To: sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Valentin Rothberg List-Id: linux-pm@vger.kernel.org Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request may fail. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Signed-off-by: Valentin Rothberg --- drivers/power/smb347-charger.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/power/smb347-charger.c b/drivers/power/smb347-charger.c index acf84e8..e9702de 100644 --- a/drivers/power/smb347-charger.c +++ b/drivers/power/smb347-charger.c @@ -842,7 +842,8 @@ static int smb347_irq_init(struct smb347_charger *smb, goto fail; ret = request_threaded_irq(irq, NULL, smb347_interrupt, - IRQF_TRIGGER_FALLING, client->name, smb); + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + client->name, smb); if (ret < 0) goto fail_gpio; -- 1.9.1