[PATCH] intel_idle: mark cpu id array as __initconst

[PATCH] intel_idle: mark cpu id array as __initconst

[Mathias Krause]

The CPU ids are only tested in intel_idle_probe() which is itself an
__init function. For the MODULE_DEVICE_TABLE() file2alias doesn't care
about the section, just about the symbol name. So it's safe to mark
the cpu id array as  __initconst so its memory can be released after
initialization is done.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
---
 drivers/idle/intel_idle.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index b0e58522780d..f5b7fc56fa4a 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -776,7 +776,7 @@ static const struct idle_cpu idle_cpu_avn = {
 #define ICPU(model, cpu) \
 	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&cpu }
 
-static const struct x86_cpu_id intel_idle_ids[] = {
+static const struct x86_cpu_id intel_idle_ids[] __initconst = {
 	ICPU(0x1a, idle_cpu_nehalem),
 	ICPU(0x1e, idle_cpu_nehalem),
 	ICPU(0x1f, idle_cpu_nehalem),
-- 
1.7.10.4

Re: [PATCH] intel_idle: mark cpu id array as __initconst

[Mathias Krause]

On 25 March 2015 at 22:15, Mathias Krause <minipli@googlemail.com> wrote:
> The CPU ids are only tested in intel_idle_probe() which is itself an
> __init function. For the MODULE_DEVICE_TABLE() file2alias doesn't care
> about the section, just about the symbol name. So it's safe to mark
> the cpu id array as  __initconst so its memory can be released after
> initialization is done.
>
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> ---
>  drivers/idle/intel_idle.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index b0e58522780d..f5b7fc56fa4a 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -776,7 +776,7 @@ static const struct idle_cpu idle_cpu_avn = {
>  #define ICPU(model, cpu) \
>         { X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&cpu }
>
> -static const struct x86_cpu_id intel_idle_ids[] = {
> +static const struct x86_cpu_id intel_idle_ids[] __initconst = {
>         ICPU(0x1a, idle_cpu_nehalem),
>         ICPU(0x1e, idle_cpu_nehalem),
>         ICPU(0x1f, idle_cpu_nehalem),
> --
> 1.7.10.4
>

Ping. Len, any objections to the patch?

Mathias