From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: 최찬우 <cw00.choi@samsung.com>, 박경민 <kyungmin.park@samsung.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: Re: [PATCH 6/6] PM / devfreq: Set the min_freq and max_freq of devfreq device
Date: Mon, 23 Nov 2015 07:21:00 +0000 (GMT) [thread overview]
Message-ID: <1427563269.125721448263260488.JavaMail.weblogic@epmlwas06a> (raw)
[]
> >
> > The value 0 is used for min/max_freq to declare
> > that min/max_freq is deactivated. Therefore, it is not
> > required to do so; they are not intended to show the hardware
> > configuration as well.
>
> This case consider the devfreq device using OPP because devfreq_set_freq_table()
> get the number of OPP entry in OPP list before setting the min_freq/max_freq.
> If the devfreq device don't use the OPP entry, devfreq_set_freq_table()
> will return without any operation.
>
> IMHO, when devfreq device uses the OPP table including the frequency,
> min_freq/max_freq should show the correct value as CPUFREQ framework.
>
The side effect of this patch shows up when opp_disable() and opp_enable()
are used.
For example,
1. dev->opp_disable(2GHz); /* 2GHz is the fastest and 1.6 is the second */
2. init devfreq of dev; /* setting max_freq @ 1.6G by this patch */
3. dev->opp_enable(2GHz);
4. 2GHz is still not active because max_freq is now 1.6GHz.
Cheers,
MyungJoo.
next reply other threads:[~2015-11-23 7:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 7:21 MyungJoo Ham [this message]
2015-11-23 8:53 ` Re: [PATCH 6/6] PM / devfreq: Set the min_freq and max_freq of devfreq device Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427563269.125721448263260488.JavaMail.weblogic@epmlwas06a \
--to=myungjoo.ham@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox