From: Joe Konno <joe.konno@linux.intel.com>
To: rjw@rjwysocki.net
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
viresh.kumar@linaro.org, kristen@linux.intel.com
Subject: [PATCH] intel_pstate: set BYT MSR with wrmsrl_on_cpu()
Date: Tue, 12 May 2015 07:59:42 -0700 [thread overview]
Message-ID: <1431442782-12061-1-git-send-email-joe.konno@linux.intel.com> (raw)
In-Reply-To: <1431017979-28349-1-git-send-email-joe.konno@linux.intel.com>
From: Joe Konno <joe.konno@intel.com>
Commit 007bea098b86 (intel_pstate: Add setting voltage value for
baytrail P states.) introduced byt_set_pstate() with the assumption that
it would always be run by the CPU whose MSR is to be written by it. It
turns out, however, that is not always the case in practice, so modify
byt_set_pstate() to enforce the MSR write done by it to always happen on
the right CPU.
v2: better commit message, remove For: tag
Fixes: 007bea098b86 ("intel_pstate: Add setting voltage value for
baytrail P states.")
Signed-off-by: Joe Konno <joe.konno@intel.com>
---
drivers/cpufreq/intel_pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 6414661ac1c4..c45d274a75c8 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -535,7 +535,7 @@ static void byt_set_pstate(struct cpudata *cpudata, int pstate)
val |= vid;
- wrmsrl(MSR_IA32_PERF_CTL, val);
+ wrmsrl_on_cpu(cpudata->cpu, MSR_IA32_PERF_CTL, val);
}
#define BYT_BCLK_FREQS 5
--
2.4.0
next prev parent reply other threads:[~2015-05-12 15:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 16:59 [PATCH] intel_pstate: set BYT MSR with wrmsrl_on_cpu() Joe Konno
2015-05-07 20:58 ` Rafael J. Wysocki
2015-05-07 23:22 ` Joe Konno
2015-05-08 13:59 ` Rafael J. Wysocki
2015-05-11 18:39 ` Kristen Carlson Accardi
2015-05-12 14:59 ` Joe Konno [this message]
2015-05-15 0:13 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431442782-12061-1-git-send-email-joe.konno@linux.intel.com \
--to=joe.konno@linux.intel.com \
--cc=kristen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).