From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Elste Subject: bq24190_charger: no status updates Date: Thu, 28 May 2015 11:05:31 +0200 Message-ID: <1432803932-5315-1-git-send-email-thomas.elste@imms.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from infosrv.imms.de ([194.95.250.51]:58184 "EHLO infosrv.imms.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932090AbbE1Jbu (ORCPT ); Thu, 28 May 2015 05:31:50 -0400 Received: from infosrv.imms.de (infosrv.imms.de [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B3D599004E for ; Thu, 28 May 2015 11:05:36 +0200 (CEST) Received: from iimail.ii.imms.de (iimail.imms.de [194.95.133.35]) by infosrv.imms.de (Postfix) with ESMTP id 743389004D for ; Thu, 28 May 2015 11:05:36 +0200 (CEST) Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: linux-pm@vger.kernel.org Cc: thomas.elste@imms.de Hi, while searching for the cause of charger events not being detected on a custom board with a BQ24190 charger, I think a found a minor problem in its driver: The bq24190_charger driver uses a flag for preventing the first change in charger status, which is generated by an initial register clear, to reach power supply subsystem via power_supply_changed. This flag is set in the probe function and is supposed to be reset after a first status change. This never happens as the condition for reset depends already on the flag not being set. I made a short patch which changes the flags reset condition. Best regards Thomas