From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Cc: linux-pm@vger.kernel.org, kernel@pengutronix.de,
Alexandre Courbot <gnurou@gmail.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Laurentiu Palcu <laurentiu.palcu@intel.com>,
Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
Subject: [PATCH] power_supply: bq24257: use flags argument of devm_gpiod_get
Date: Fri, 12 Jun 2015 09:24:42 +0200 [thread overview]
Message-ID: <1434093882-31795-1-git-send-email-u.kleine-koenig@pengutronix.de> (raw)
Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
which appeared in v3.17-rc1, the gpiod_get* functions take an additional
parameter that allows to specify direction and initial value for output.
Simplify driver accordingly. Furthermore this is one caller less that
stops us making the flags argument to gpiod_get*() mandatory.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
this patch applies to next and is only necessary on top of 2219a935963e
(power_supply: Add TI BQ24257 charger driver).
Note I plan to make the flags parameter mandatory for 4.3. So unless
this change gets into 4.2, would it be ok to let it go in via the gpio
tree?
Best regards
Uwe
drivers/power/bq24257_charger.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/power/bq24257_charger.c b/drivers/power/bq24257_charger.c
index ce7f5bbfd5e3..d072f1838526 100644
--- a/drivers/power/bq24257_charger.c
+++ b/drivers/power/bq24257_charger.c
@@ -611,28 +611,24 @@ static int bq24257_irq_probe(struct bq24257_device *bq)
int ret;
struct gpio_desc *stat_irq;
- stat_irq = devm_gpiod_get_index(bq->dev, BQ24257_STAT_IRQ, 0);
+ stat_irq = devm_gpiod_get_index(bq->dev, BQ24257_STAT_IRQ, 0, GPIOD_IN);
if (IS_ERR(stat_irq)) {
dev_err(bq->dev, "could not probe stat_irq pin\n");
return PTR_ERR(stat_irq);
}
- ret = gpiod_direction_input(stat_irq);
- if (ret < 0)
- return ret;
-
return gpiod_to_irq(stat_irq);
}
static int bq24257_pg_gpio_probe(struct bq24257_device *bq)
{
- bq->pg = devm_gpiod_get_index(bq->dev, BQ24257_PG_GPIO, 0);
- if (IS_ERR(bq->pg)) {
+ bq->pg = devm_gpiod_get_index(bq->dev, BQ24257_PG_GPIO, 0, GPIOD_IN);
+ if (IS_ERR(bq->pg))
dev_err(bq->dev, "could not probe PG pin\n");
return PTR_ERR(bq->pg);
}
- return gpiod_direction_input(bq->pg);
+ return 0;
}
static int bq24257_fw_probe(struct bq24257_device *bq)
--
2.1.4
next reply other threads:[~2015-06-12 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 7:24 Uwe Kleine-König [this message]
2015-06-12 8:54 ` [PATCH v2] power_supply: bq24257: use flags argument of devm_gpiod_get Uwe Kleine-König
2015-06-13 2:39 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434093882-31795-1-git-send-email-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gnurou@gmail.com \
--cc=k.kozlowski.k@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=laurentiu.palcu@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).