From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-pm@vger.kernel.org
Cc: Zhang Rui <rui.zhang@intel.com>,
linux-kernel@vger.kernel.org,
Eduardo Valentin <edubezval@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: [PATCH 4/4] thermal: Add comment explaining test for critical temperature
Date: Mon, 6 Jul 2015 09:46:17 +0200 [thread overview]
Message-ID: <1436168777-10463-5-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1436168777-10463-1-git-send-email-s.hauer@pengutronix.de>
The code testing if a temperature should be emulated or not is
not obvious. Add a comment explaining why this test is done.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
---
drivers/thermal/thermal_core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 67296da..956684e 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -498,6 +498,11 @@ int thermal_zone_get_temp(struct thermal_zone_device *tz, unsigned long *temp)
}
}
+ /*
+ * Only allow emulating a temperature when the real temperature
+ * is below the critical temperature so that the emulation code
+ * cannot hide critical conditions.
+ */
if (!ret && *temp < crit_temp)
*temp = tz->emul_temperature;
}
--
2.1.4
prev parent reply other threads:[~2015-07-06 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 7:46 thermal: Cleanup patches Sascha Hauer
2015-07-06 7:46 ` [PATCH 1/4] thermal: trivial: fix typo in comment Sascha Hauer
2015-07-31 8:46 ` Sascha Hauer
2015-07-06 7:46 ` [PATCH 2/4] thermal: remove unnecessary call to thermal_zone_device_set_polling Sascha Hauer
2015-07-06 7:46 ` [PATCH 3/4] thermal: Use IS_ENABLED instead of #ifdef Sascha Hauer
2015-07-06 10:24 ` Lukasz Majewski
2015-07-06 7:46 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436168777-10463-5-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).