From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [RFC PATCH 02/16] x86/efi: Add get and set variable to EFI services pointer table Date: Thu, 30 Jul 2015 16:19:58 +0100 Message-ID: <1438269598.11322.2.camel@intel.com> References: <1437056730-15247-1-git-send-email-jlee@suse.com> <1437056730-15247-3-git-send-email-jlee@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1437056730-15247-3-git-send-email-jlee@suse.com> Sender: linux-kernel-owner@vger.kernel.org To: "Lee, Chun-Yi" Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Matthew Garrett , Len Brown , Pavel Machek , Josh Boyer , Vojtech Pavlik , Jiri Kosina , "H. Peter Anvin" , "Lee, Chun-Yi" List-Id: linux-pm@vger.kernel.org On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > Add get variable and set variable function to EFI services pointer > table for supporting later functions of hibernate signature > verification to keep the HMAC key in efi boot service veriable. > > Signed-off-by: Lee, Chun-Yi Maybe mention that we want to be able to read/write variables from within the EFI boot stub? That's really why you want to add {get,set}_variable pointers. s/veriable/variable/ Rest of the patch looks good.