[PATCH] power: align wakeup_sources format

[PATCH] power: align wakeup_sources format

[check.kernel]

From: yangdongdong <yangdongdong@xiaomi.com>

This aligns every column of elements in wakeup_sources to
conveniently check any specific column for suspicious power
consumption wakeup source or for other easily readable purpose.

Signed-off-by: Andy Yang <yangdongdong@xiaomi.com>
Signed-off-by: Linghua Gu <gulinghua@xiaomi.com>
---
 drivers/base/power/wakeup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
index 51f15bc..b6fe9e6 100644
--- a/drivers/base/power/wakeup.c
+++ b/drivers/base/power/wakeup.c
@@ -998,7 +998,7 @@ static int print_wakeup_source_stats(struct seq_file *m,
 		active_time = ktime_set(0, 0);
 	}
 
-	seq_printf(m, "%-12s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
+	seq_printf(m, "%-32s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
 		   ws->name, active_count, ws->event_count,
 		   ws->wakeup_count, ws->expire_count,
 		   ktime_to_ms(active_time), ktime_to_ms(total_time),
@@ -1018,7 +1018,7 @@ static int wakeup_sources_stats_show(struct seq_file *m, void *unused)
 {
 	struct wakeup_source *ws;
 
-	seq_puts(m, "name\t\tactive_count\tevent_count\twakeup_count\t"
+	seq_puts(m, "name\t\t\t\t\tactive_count\tevent_count\twakeup_count\t"
 		"expire_count\tactive_since\ttotal_time\tmax_time\t"
 		"last_change\tprevent_suspend_time\n");
 
-- 
2.5.0

Re: [PATCH] power: align wakeup_sources format

[Greg Kroah-Hartman]

On Wed, Aug 12, 2015 at 12:31:14PM +0800, check.kernel@gmail.com wrote:
> From: yangdongdong <yangdongdong@xiaomi.com>

Use the same name here as you used for the signed-off-by: line please.

Please fix and resend.

thanks,

greg k-h

[PATCH] power: align wakeup_sources format

[check.kernel]

From: yangdongdong <yangdongdong@xiaomi.com>

This aligns every column of elements in wakeup_sources to
conveniently check any specific column for suspicious power
consumption wakeup source or for other easily readable purpose.

Signed-off-by: yangdongdong <yangdongdong@xiaomi.com>
Signed-off-by: Linghua Gu <gulinghua@xiaomi.com>
---
 drivers/base/power/wakeup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
index 51f15bc..b6fe9e6 100644
--- a/drivers/base/power/wakeup.c
+++ b/drivers/base/power/wakeup.c
@@ -998,7 +998,7 @@ static int print_wakeup_source_stats(struct seq_file *m,
 		active_time = ktime_set(0, 0);
 	}
 
-	seq_printf(m, "%-12s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
+	seq_printf(m, "%-32s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
 		   ws->name, active_count, ws->event_count,
 		   ws->wakeup_count, ws->expire_count,
 		   ktime_to_ms(active_time), ktime_to_ms(total_time),
@@ -1018,7 +1018,7 @@ static int wakeup_sources_stats_show(struct seq_file *m, void *unused)
 {
 	struct wakeup_source *ws;
 
-	seq_puts(m, "name\t\tactive_count\tevent_count\twakeup_count\t"
+	seq_puts(m, "name\t\t\t\t\tactive_count\tevent_count\twakeup_count\t"
 		"expire_count\tactive_since\ttotal_time\tmax_time\t"
 		"last_change\tprevent_suspend_time\n");
 
-- 
2.5.0

The signed name is updated from "Andy Yang" to yangdongdong.

Best Regards,
Andy

On Wed, Aug 12, 2015 at 12:31:14PM +0800, check.kernel@gmail.com wrote:
> From: yangdongdong <yangdongdong@xiaomi.com>

Use the same name here as you used for the signed-off-by: line please.

Please fix and resend.

thanks,

greg k-h

Re: [PATCH] power: align wakeup_sources format

[Greg Kroah-Hartman]

On Wed, Aug 12, 2015 at 02:12:38PM +0800, check.kernel@gmail.com wrote:
> From: yangdongdong <yangdongdong@xiaomi.com>

As mentioned before, please fix this.

[PATCH] power: align wakeup_sources format

[check.kernel]

From: yangdongdong <yangdongdong@xiaomi.com>

This aligns every column of elements in wakeup_sources to
conveniently check any specific column for suspicious power
consumption wakeup source or for other easily readable purpose.

Signed-off-by: yangdongdong <yangdongdong@xiaomi.com>
---
 drivers/base/power/wakeup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
index 51f15bc..b6fe9e6 100644
--- a/drivers/base/power/wakeup.c
+++ b/drivers/base/power/wakeup.c
@@ -998,7 +998,7 @@ static int print_wakeup_source_stats(struct seq_file *m,
 		active_time = ktime_set(0, 0);
 	}
 
-	seq_printf(m, "%-12s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
+	seq_printf(m, "%-32s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
 		   ws->name, active_count, ws->event_count,
 		   ws->wakeup_count, ws->expire_count,
 		   ktime_to_ms(active_time), ktime_to_ms(total_time),
@@ -1018,7 +1018,7 @@ static int wakeup_sources_stats_show(struct seq_file *m, void *unused)
 {
 	struct wakeup_source *ws;
 
-	seq_puts(m, "name\t\tactive_count\tevent_count\twakeup_count\t"
+	seq_puts(m, "name\t\t\t\t\tactive_count\tevent_count\twakeup_count\t"
 		"expire_count\tactive_since\ttotal_time\tmax_time\t"
 		"last_change\tprevent_suspend_time\n");
 
-- 
2.5.0

The signed name has been updated.

Thanks,
yangdongdong

On Wed, Aug 12, 2015 at 02:12:38PM +0800, check.kernel@gmail.com wrote:
> From: yangdongdong <yangdongdong@xiaomi.com>

As mentioned before, please fix this.

The signed name is updated from "Andy Yang" to yangdongdong.

Best Regards,
Andy

On Wed, Aug 12, 2015 at 12:31:14PM +0800, check.kernel@gmail.com wrote:
> From: yangdongdong <yangdongdong@xiaomi.com>

Use the same name here as you used for the signed-off-by: line please.

Please fix and resend.

thanks,

greg k-h

Re: [PATCH] power: align wakeup_sources format

[杜慧]

That is her full name:)
________________________________________
From: Rafael J. Wysocki <rjw@rjwysocki.net>
Sent: Friday, August 14, 2015 16:59
To: check.kernel@gmail.com
Cc: Greg Kroah-Hartman; Len Brown; Pavel Machek; 杜慧; 顾凌华; linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; 杨冬东
Subject: Re: [PATCH] power: align wakeup_sources format

On Thursday, August 13, 2015 10:24:49 AM check.kernel@gmail.com wrote:
> From: yangdongdong <yangdongdong@xiaomi.com>
>
> This aligns every column of elements in wakeup_sources to
> conveniently check any specific column for suspicious power
> consumption wakeup source or for other easily readable purpose.
>
> Signed-off-by: yangdongdong <yangdongdong@xiaomi.com>

Is yangdongdong your real name, ie. one you would use when checking in
at a hotel etc.?  If not, it is not appropriate for signing off a patch.

Thanks,
Rafael

Re: [PATCH] power: align wakeup_sources format

[Rafael J. Wysocki]

On Thursday, August 13, 2015 10:24:49 AM check.kernel@gmail.com wrote:
> From: yangdongdong <yangdongdong@xiaomi.com>
> 
> This aligns every column of elements in wakeup_sources to
> conveniently check any specific column for suspicious power
> consumption wakeup source or for other easily readable purpose.
> 
> Signed-off-by: yangdongdong <yangdongdong@xiaomi.com>

Is yangdongdong your real name, ie. one you would use when checking in
at a hotel etc.?  If not, it is not appropriate for signing off a patch.

Thanks,
Rafael

[PATCH] power: align wakeup_sources format

[check.kernel]

From: yangdongdong <yangdongdong@xiaomi.com>

This aligns every column of elements in wakeup_sources to
conveniently check any specific column for suspicious power
consumption wakeup source or for other easily readable purpose.

Signed-off-by: Dongdong Yang <yangdongdong@xiaomi.com>
Signed-off-by: Linghua Gu <gulinghua@xiaomi.com>
---
 drivers/base/power/wakeup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
index 51f15bc..b6fe9e6 100644
--- a/drivers/base/power/wakeup.c
+++ b/drivers/base/power/wakeup.c
@@ -998,7 +998,7 @@ static int print_wakeup_source_stats(struct seq_file *m,
 		active_time = ktime_set(0, 0);
 	}
 
-	seq_printf(m, "%-12s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
+	seq_printf(m, "%-32s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
 		   ws->name, active_count, ws->event_count,
 		   ws->wakeup_count, ws->expire_count,
 		   ktime_to_ms(active_time), ktime_to_ms(total_time),
@@ -1018,7 +1018,7 @@ static int wakeup_sources_stats_show(struct seq_file *m, void *unused)
 {
 	struct wakeup_source *ws;
 
-	seq_puts(m, "name\t\tactive_count\tevent_count\twakeup_count\t"
+	seq_puts(m, "name\t\t\t\t\tactive_count\tevent_count\twakeup_count\t"
 		"expire_count\tactive_since\ttotal_time\tmax_time\t"
 		"last_change\tprevent_suspend_time\n");
 
-- 
2.5.0

On Thursday, August 13, 2015 10:24:49 AM check.kernel@gmail.com wrote:
> From: yangdongdong <yangdongdong@xiaomi.com>
>
> This aligns every column of elements in wakeup_sources to
> conveniently check any specific column for suspicious power
> consumption wakeup source or for other easily readable purpose.
>
> Signed-off-by: yangdongdong <yangdongdong@xiaomi.com>

Is yangdongdong your real name, ie. one you would use when checking in
at a hotel etc.?  If not, it is not appropriate for signing off a patch.

Thanks,
Rafael

That is her full name:)
________________________________________
From: Rafael J. Wysocki <rjw@rjwysocki.net>
Sent: Friday, August 14, 2015 16:59
To: check.kernel@gmail.com
Subject: Re: [PATCH] power: align wakeup_sources format

________________________________________

My surname is Yang, and given name is Dongdong. It is my real name and be
printed at my passport. Thanks for your prudence to confirm it with me.
BTW, Andy Yang is my English name when I worked for foreign company.

Best Regards,
Dongdong Yang

Re: [PATCH] power: align wakeup_sources format

[Pavel Machek]

On Fri 2015-08-14 16:59:27, check.kernel@gmail.com wrote:
> From: yangdongdong <yangdongdong@xiaomi.com>
> 
> This aligns every column of elements in wakeup_sources to
> conveniently check any specific column for suspicious power
> consumption wakeup source or for other easily readable purpose.
> 
> Signed-off-by: Dongdong Yang <yangdongdong@xiaomi.com>
> Signed-off-by: Linghua Gu <gulinghua@xiaomi.com>
> ---
>  drivers/base/power/wakeup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Its debugfs, so format update should be ok.

Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html