[PATCH] PM / Domains: Make pm_genpd_init() available to modules

[PATCH] PM / Domains: Make pm_genpd_init() available to modules

[Rajendra Nayak]

Export symbol pm_genpd_init so it can be used in loadable
kernel modules

Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/base/power/domain.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 0ee43c1..578d121 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1952,6 +1952,7 @@ void pm_genpd_init(struct generic_pm_domain *genpd,
 	list_add(&genpd->gpd_list_node, &gpd_list);
 	mutex_unlock(&gpd_list_lock);
 }
+EXPORT_SYMBOL_GPL(pm_genpd_init);
 
 #ifdef CONFIG_PM_GENERIC_DOMAINS_OF
 /*
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCH] PM / Domains: Make pm_genpd_init() available to modules

[Stephen Boyd]

On 08/13, Rajendra Nayak wrote:
> Export symbol pm_genpd_init so it can be used in loadable
> kernel modules
> 
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---

I'd like to take this through the clk tree somehow so that we can
merge the rest of the GDSC series this coming cycle.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH] PM / Domains: Make pm_genpd_init() available to modules

[Rajendra Nayak]

On 08/13/2015 11:41 PM, Stephen Boyd wrote:
> On 08/13, Rajendra Nayak wrote:
>> Export symbol pm_genpd_init so it can be used in loadable
>> kernel modules
>>
>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> ---
>
> I'd like to take this through the clk tree somehow so that we can
> merge the rest of the GDSC series this coming cycle.

Ulf/Rafael, if you don't have any issues with the patch, and are fine
with Stephen taking this through the clk tree, would you be able to ack
this please? thanks.

regards,
Rajendra

Re: [PATCH] PM / Domains: Make pm_genpd_init() available to modules

[Geert Uytterhoeven]

On Thu, Aug 13, 2015 at 8:21 AM, Rajendra Nayak <rnayak@codeaurora.org> wrote:
> Export symbol pm_genpd_init so it can be used in loadable
> kernel modules
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>

Assuming you're aware of the consequences:
  - Modular PM Domain drivers don't work for "critical" devices where the
    driver is started from *OF_DECLARE(),
  - This may depend on "PM / Domains: Return -EPROBE_DEFER if we fail to
    init or turn-on domain" in pm/linux-next
    https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=311fa6adf92c5110057daa439fdaff012864aa2b

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] PM / Domains: Make pm_genpd_init() available to modules

[Kevin Hilman]

Geert Uytterhoeven <geert@linux-m68k.org> writes:

> On Thu, Aug 13, 2015 at 8:21 AM, Rajendra Nayak <rnayak@codeaurora.org> wrote:
>> Export symbol pm_genpd_init so it can be used in loadable
>> kernel modules
>>
>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Assuming you're aware of the consequences:
>   - Modular PM Domain drivers don't work for "critical" devices where the
>     driver is started from *OF_DECLARE(),
>   - This may depend on "PM / Domains: Return -EPROBE_DEFER if we fail to
>     init or turn-on domain" in pm/linux-next
>     https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=311fa6adf92c5110057daa439fdaff012864aa2b
>
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Right, things can get "interesting" and there are known limitations, but
we shouldn't prevent it, and also it might help us fix the above
limitations.

Acked-by: Kevin Hilman <khilman@linaro.org>

Rafael, can you pick this one up?  I think it's better to go through the
PM tree.  v4.2 would be ideal, but I realize it's probably a bit late
for that.

Kevin