From: Andreas Dannenberg <dannenberg@ti.com>
To: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Laurentiu Palcu <laurentiu.palcu@intel.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Ramakrishna Pallala <ramakrishna.pallala@intel.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-api@vger.kernel.org, Andreas Dannenberg <dannenberg@ti.com>
Subject: [PATCH v6 02/14] power: bq24257: Remove IRQ config through stat-gpios
Date: Thu, 24 Sep 2015 22:26:46 -0500 [thread overview]
Message-ID: <1443151618-29742-3-git-send-email-dannenberg@ti.com> (raw)
In-Reply-To: <1443151618-29742-1-git-send-email-dannenberg@ti.com>
At the time the driver was written GpioInt resources in ACPI were not
passed to the driver in client->irq, as opposed to DT enumeration. To
accommodate this use case, a "stat-gpios" property was introduced to
allow configuring the IRQ.
However this issue with ACPI was fixed in commit "845c877 i2c / ACPI:
Assign IRQ for devices that have GpioInt automatically" and makes this
workaround no longer necessary, hence we can remove the support for the
"stat-gpios" property and the associated code from the bq24257 driver.
Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
---
drivers/power/bq24257_charger.c | 28 ++++------------------------
1 file changed, 4 insertions(+), 24 deletions(-)
diff --git a/drivers/power/bq24257_charger.c b/drivers/power/bq24257_charger.c
index 5859bc7..69b53d0 100644
--- a/drivers/power/bq24257_charger.c
+++ b/drivers/power/bq24257_charger.c
@@ -36,7 +36,6 @@
#define BQ24257_REG_7 0x06
#define BQ24257_MANUFACTURER "Texas Instruments"
-#define BQ24257_STAT_IRQ "stat"
#define BQ24257_PG_GPIO "pg"
#define BQ24257_ILIM_SET_DELAY 1000 /* msec */
@@ -606,19 +605,6 @@ static int bq24257_power_supply_init(struct bq24257_device *bq)
return 0;
}
-static int bq24257_irq_probe(struct bq24257_device *bq)
-{
- struct gpio_desc *stat_irq;
-
- stat_irq = devm_gpiod_get_index(bq->dev, BQ24257_STAT_IRQ, 0, GPIOD_IN);
- if (IS_ERR(stat_irq)) {
- dev_err(bq->dev, "could not probe stat_irq pin\n");
- return PTR_ERR(stat_irq);
- }
-
- return gpiod_to_irq(stat_irq);
-}
-
static int bq24257_pg_gpio_probe(struct bq24257_device *bq)
{
bq->pg = devm_gpiod_get_index(bq->dev, BQ24257_PG_GPIO, 0, GPIOD_IN);
@@ -740,21 +726,15 @@ static int bq24257_probe(struct i2c_client *client,
return ret;
}
- if (client->irq <= 0)
- client->irq = bq24257_irq_probe(bq);
-
- if (client->irq < 0) {
- dev_err(dev, "no irq resource found\n");
- return client->irq;
- }
-
ret = devm_request_threaded_irq(dev, client->irq, NULL,
bq24257_irq_handler_thread,
IRQF_TRIGGER_FALLING |
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
- BQ24257_STAT_IRQ, bq);
- if (ret)
+ "bq24257", bq);
+ if (ret) {
+ dev_err(dev, "Failed to request IRQ #%d\n", client->irq);
return ret;
+ }
ret = bq24257_power_supply_init(bq);
if (ret < 0)
--
1.9.1
next prev parent reply other threads:[~2015-09-25 3:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 3:26 [PATCH v6 00/14] power: bq24257: Add support for bq24250/bq24251 Andreas Dannenberg
2015-09-25 3:26 ` Andreas Dannenberg [this message]
2015-09-25 3:26 ` [PATCH v6 03/14] power: bq24257: Streamline input current limit setup Andreas Dannenberg
[not found] ` <1443151618-29742-4-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-25 13:23 ` Laurentiu Palcu
2015-09-25 13:52 ` Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 05/14] power: bq24257: Add bit definition for temp sense enable Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 06/14] power: bq24257: Allow manual setting of input current limit Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 07/14] power: bq24257: Add SW-based approach for Power Good determination Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 08/14] power: bq24257: Use managed power supply register Andreas Dannenberg
2015-09-25 13:43 ` Laurentiu Palcu
[not found] ` <1443151618-29742-1-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-25 3:26 ` [PATCH v6 01/14] dt: power: bq24257-charger: Cover additional devices Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 04/14] power: bq24257: Add basic support for bq24250/bq24251 Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 09/14] power: bq24257: Add over voltage protection setting support Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 10/14] power: bq24257: Add input DPM voltage threshold " Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 11/14] power: bq24257: Allow input current limit sysfs access Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 12/14] power: bq24257: Add various device-specific sysfs properties Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 13/14] power: bq24257: Add platform data based initialization Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 14/14] Documentation: power: bq24257: Document exported sysfs entries Andreas Dannenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443151618-29742-3-git-send-email-dannenberg@ti.com \
--to=dannenberg@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=k.kozlowski@samsung.com \
--cc=laurentiu.palcu@intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ramakrishna.pallala@intel.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).