From: Joe Perches <joe@perches.com>
To: Saurabh Sengar <saurabh.truth@gmail.com>
Cc: rjw@rjwysocki.net, pavel@ucw.cz, len.brown@intel.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: power: replacing printk
Date: Tue, 27 Oct 2015 12:00:43 -0700 [thread overview]
Message-ID: <1445972443.2757.34.camel@perches.com> (raw)
In-Reply-To: <1445919397-6807-1-git-send-email-saurabh.truth@gmail.com>
On Tue, 2015-10-27 at 09:46 +0530, Saurabh Sengar wrote:
> replacing prink(s) with appropriate pr_info and pr_err
[]
> diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
[]
> @@ -486,9 +486,9 @@ static int enter_state(suspend_state_t state)
>
> #ifndef CONFIG_SUSPEND_SKIP_SYNC
> trace_suspend_resume(TPS("sync_filesystems"), 0, true);
> - printk(KERN_INFO "PM: Syncing filesystems ... ");
> + pr_info("PM: Syncing filesystems ... ");
> sys_sync();
> - printk("done.\n");
> + pr_info("done.\n");
> trace_suspend_resume(TPS("sync_filesystems"), 0, false);
> #endif
>
This isn't the same output.
The original code emits on a single line.
This new code emits on two lines, the second
line without a "PM: " prefix.
prev parent reply other threads:[~2015-10-27 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 4:16 [PATCH] kernel: power: replacing printk Saurabh Sengar
2015-10-27 19:00 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445972443.2757.34.camel@perches.com \
--to=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=saurabh.truth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).