From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Subject: Re: [PATCH 2/5] cpufreq: imx6q: Fix wrong device in devm_kzalloc Date: Wed, 28 Oct 2015 09:49:09 +0100 Message-ID: <1446022149.3138.5.camel@pengutronix.de> References: <1446019154-16384-1-git-send-email-s.hauer@pengutronix.de> <1446019154-16384-3-git-send-email-s.hauer@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:53502 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964813AbbJ1ItM (ORCPT ); Wed, 28 Oct 2015 04:49:12 -0400 In-Reply-To: <1446019154-16384-3-git-send-email-s.hauer@pengutronix.de> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Sascha Hauer Cc: linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Viresh Kumar , "Rafael J . Wysocki" , kernel@pengutronix.de, Shawn Guo , Heiner Kallweit Am Mittwoch, den 28.10.2015, 08:59 +0100 schrieb Sascha Hauer: > devm_kzalloc must be called with the device that is actually probed, > not with cpu_dev which resources are not freed when probe fails. > > Signed-off-by: Sascha Hauer I think I've said this already on the last round, Reviewed-by: Lucas Stach > --- > drivers/cpufreq/imx6q-cpufreq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c > index fabd144..6fefd19 100644 > --- a/drivers/cpufreq/imx6q-cpufreq.c > +++ b/drivers/cpufreq/imx6q-cpufreq.c > @@ -260,7 +260,8 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev) > } > > /* Make imx6_soc_volt array's size same as arm opp number */ > - imx6_soc_volt = devm_kzalloc(cpu_dev, sizeof(*imx6_soc_volt) * num, GFP_KERNEL); > + imx6_soc_volt = devm_kzalloc(&pdev->dev, > + sizeof(*imx6_soc_volt) * num, GFP_KERNEL); > if (imx6_soc_volt == NULL) { > ret = -ENOMEM; > goto free_freq_table; -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ |