Re: [PATCH] PM / sleep: define inline functions

Eric Anholt
2015-12-17T00:41:37Z

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

Sudip Mukherjee <sudipm.mukherjee@gmail.com> writes:

> If CONFIG_PM_SLEEP is not defined then the functions are defined as
> NULL. And as a result we are getting build failure with
> alpha allmodconfig with the error:
>
> drivers/gpu/drm/vc4/vc4_v3d.c: In function 'vc4_v3d_set_power':
> include/linux/stddef.h:7:14: error: called object is not a function or function pointer
> #define NULL ((void *)0)
> ^
> include/linux/pm.h:776:30: note: in expansion of macro 'NULL'
> #define pm_generic_poweroff NULL
> ^
> drivers/gpu/drm/vc4/vc4_v3d.c:157:10: note: in expansion of macro 'pm_generic_poweroff'
> return pm_generic_poweroff(&vc4->v3d->pdev->dev);
> ^
> include/linux/stddef.h:7:14: error: called object is not a function or function pointer
> #define NULL ((void *)0)
> ^
> include/linux/pm.h:764:28: note: in expansion of macro 'NULL'
> #define pm_generic_resume NULL
> ^
> drivers/gpu/drm/vc4/vc4_v3d.c:159:10: note: in expansion of macro 'pm_generic_resume'
> return pm_generic_resume(&vc4->v3d->pdev->dev);
> ^
>
> Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.")
> Cc: Eric Anholt <eric@anholt.net>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>

I'm happy with this solution, and would also be willing to just depend
on the config option as well. Whatever people prefer.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]