Re: [PATCH] PM / devfreq: Fix governor_store()

[MyungJoo Ham <myungjoo.ham@samsung.com>]

> Writing the currently set governor into sysfs currently
> seems to fail.
> Fix this by setting the return code to zero before
> leaving governor_store().
> 
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>

Thank you for pointing that out.

Applied.


Cheers,
MyungJoo

> ---
>  drivers/devfreq/devfreq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 3927ed9..4f1b0ce 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -795,8 +795,10 @@ static ssize_t governor_store(struct device *dev, struct device_attribute *attr,
>  		ret = PTR_ERR(governor);
>  		goto out;
>  	}
> -	if (df->governor == governor)
> +	if (df->governor == governor) {
> +		ret = 0;
>  		goto out;
> +	}
>  
>  	if (df->governor) {
>  		ret = df->governor->event_handler(df, DEVFREQ_GOV_STOP, NULL);
> -- 
> 2.0.5