linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tejun Heo <tj@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	"David S . Miller" <davem@davemloft.net>,
	David Airlie <airlied@linux.ie>,
	Andrew Morton <akpm@linux-foundation.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v3 2/9] device property: convert to use match_string() helper
Date: Fri,  8 Jan 2016 15:09:11 +0200	[thread overview]
Message-ID: <1452258558-119552-3-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1452258558-119552-1-git-send-email-andriy.shevchenko@linux.intel.com>

The new helper returns index of the mathing string in an array. We would use it
here.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/base/property.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/base/property.c b/drivers/base/property.c
index c359351..f902b55 100644
--- a/drivers/base/property.c
+++ b/drivers/base/property.c
@@ -647,7 +647,7 @@ int fwnode_property_match_string(struct fwnode_handle *fwnode,
 	const char *propname, const char *string)
 {
 	const char **values;
-	int nval, ret, i;
+	int nval, ret;
 
 	nval = fwnode_property_read_string_array(fwnode, propname, NULL, 0);
 	if (nval < 0)
@@ -664,13 +664,7 @@ int fwnode_property_match_string(struct fwnode_handle *fwnode,
 	if (ret < 0)
 		goto out;
 
-	ret = -ENODATA;
-	for (i = 0; i < nval; i++) {
-		if (!strcmp(values[i], string)) {
-			ret = i;
-			break;
-		}
-	}
+	ret = match_string(values, nval, string);
 out:
 	kfree(values);
 	return ret;
-- 
2.6.4

  parent reply	other threads:[~2016-01-08 13:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 13:09 [PATCH v3 0/9] lib/string: introduce match_string() helper Andy Shevchenko
2016-01-08 13:09 ` [PATCH v3 1/9] " Andy Shevchenko
2016-01-08 13:09 ` Andy Shevchenko [this message]
2016-01-08 23:33   ` [PATCH v3 2/9] device property: convert to use " Rafael J. Wysocki
2016-01-28 12:40     ` Andy Shevchenko
2016-01-08 13:09 ` [PATCH v3 3/9] pinctrl: " Andy Shevchenko
2016-01-08 13:09 ` [PATCH v3 4/9] drm/edid: " Andy Shevchenko
2016-01-08 13:09 ` [PATCH v3 5/9] power: charger_manager: " Andy Shevchenko
2016-01-08 13:09 ` [PATCH v3 6/9] power: ab8500: " Andy Shevchenko
2016-01-08 13:09 ` [PATCH v3 7/9] ata: hpt366: " Andy Shevchenko
2016-01-08 13:09 ` [PATCH v3 8/9] ide: " Andy Shevchenko
2016-01-08 13:09 ` [PATCH v3 9/9] usb: common: " Andy Shevchenko
2016-01-08 13:19 ` [PATCH v3 0/9] lib/string: introduce " Al Viro
2016-01-08 14:13   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452258558-119552-3-git-send-email-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=dbaryshkov@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).