linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
	"Juri Lelli <Lelli" <juri.lelli@arm.com>,
	"Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
Subject: [PATCH RESEND] cpufreq: Use list_is_last() to check last entry of the policy list
Date: Wed, 27 Jan 2016 12:02:26 +0530	[thread overview]
Message-ID: <1453876346-21869-1-git-send-email-ego@linux.vnet.ibm.com> (raw)
In-Reply-To: <1453715167-26165-1-git-send-email-ego@linux.vnet.ibm.com>

Currently next_policy() explicitly checks if a policy is the last
policy in the cpufreq_policy_list. Use the standard list_is_last
primitive instead.

Cc: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
---
The earlier version one was based on an Juri's experimental branch. 
I have based this one on linux-pm.git linux-next branch.

 drivers/cpufreq/cpufreq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index c35e7da..e979ec7 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -48,11 +48,11 @@ static struct cpufreq_policy *next_policy(struct cpufreq_policy *policy,
 					  bool active)
 {
 	do {
-		policy = list_next_entry(policy, policy_list);
-
 		/* No more policies in the list */
-		if (&policy->policy_list == &cpufreq_policy_list)
+		if (list_is_last(&policy->policy_list, &cpufreq_policy_list))
 			return NULL;
+
+		policy = list_next_entry(policy, policy_list);
 	} while (!suitable_policy(policy, active));
 
 	return policy;
-- 
1.9.3


  parent reply	other threads:[~2016-01-27  6:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25  9:46 [PATCH] cpufreq: Use list_is_last() to check last entry of the policy list Gautham R. Shenoy
2016-01-25  9:50 ` Viresh Kumar
2016-01-25 11:18   ` Juri Lelli
2016-01-25 11:22     ` Viresh Kumar
2016-01-27  5:57       ` Gautham R Shenoy
2016-01-27  6:09     ` Gautham R Shenoy
2016-01-27 10:10       ` Juri Lelli
2016-01-27 11:12         ` Gautham R Shenoy
2016-01-27  6:32 ` Gautham R. Shenoy [this message]
2016-01-27  6:36   ` [PATCH RESEND] " Viresh Kumar
2016-01-27 22:55     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453876346-21869-1-git-send-email-ego@linux.vnet.ibm.com \
    --to=ego@linux.vnet.ibm.com \
    --cc=juri.lelli@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=shilpa.bhat@linux.vnet.ibm.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).