linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/cpuidle: coupled: remove unused define cpuidle_coupled_lock
@ 2016-01-27 19:26 Anders Roxell
  2016-01-27 22:52 ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Anders Roxell @ 2016-01-27 19:26 UTC (permalink / raw)
  To: rjw, daniel.lezcano; +Cc: linux-pm, linux-kernel, linux-rt-users, Anders Roxell

This was found with the -RT patch enabled, but the fix should apply to
non-RT also.

Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
warning without this fix:
../drivers/cpuidle/coupled.c:122:21: warning: 'cpuidle_coupled_lock'
defined but not used [-Wunused-variable]

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 drivers/cpuidle/coupled.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
index 344058f..d5657d5 100644
--- a/drivers/cpuidle/coupled.c
+++ b/drivers/cpuidle/coupled.c
@@ -119,7 +119,6 @@ struct cpuidle_coupled {
 
 #define CPUIDLE_COUPLED_NOT_IDLE	(-1)
 
-static DEFINE_MUTEX(cpuidle_coupled_lock);
 static DEFINE_PER_CPU(struct call_single_data, cpuidle_coupled_poke_cb);
 
 /*
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/cpuidle: coupled: remove unused define cpuidle_coupled_lock
  2016-01-27 19:26 [PATCH] drivers/cpuidle: coupled: remove unused define cpuidle_coupled_lock Anders Roxell
@ 2016-01-27 22:52 ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2016-01-27 22:52 UTC (permalink / raw)
  To: Anders Roxell; +Cc: daniel.lezcano, linux-pm, linux-kernel, linux-rt-users

On Wednesday, January 27, 2016 08:26:54 PM Anders Roxell wrote:
> This was found with the -RT patch enabled, but the fix should apply to
> non-RT also.
> 
> Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
> warning without this fix:
> ../drivers/cpuidle/coupled.c:122:21: warning: 'cpuidle_coupled_lock'
> defined but not used [-Wunused-variable]
> 
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

Applied, thanks!

Rafael

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-01-27 22:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-27 19:26 [PATCH] drivers/cpuidle: coupled: remove unused define cpuidle_coupled_lock Anders Roxell
2016-01-27 22:52 ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).