linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Mel Gorman <mgorman@techsingularity.net>,
	Rafael Wysocki <rjw@rjwysocki.net>
Cc: Doug Smythies <dsmythies@telus.net>,
	Stephane Gasparini <stephane.gasparini@linux.intel.com>,
	Dirk Brandewie <dirk.j.brandewie@intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Matt Fleming <matt@codeblueprint.co.uk>,
	Mike Galbraith <umgwanakikbuti@gmail.com>,
	Linux-PM <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] intel_pstate: Increase hold-off time before samples are scaled v2
Date: Tue, 23 Feb 2016 13:50:34 -0800	[thread overview]
Message-ID: <1456264234.8680.155.camel@linux.intel.com> (raw)
In-Reply-To: <1456237784-17205-1-git-send-email-mgorman@techsingularity.net>

[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]

On Tue, 2016-02-23 at 14:29 +0000, Mel Gorman wrote:
> Added a suggested change from Doug Smythies and can add a Signed-off-
> by
> if Doug is ok with that.
> 
> Changelog since v1
> o Remove divide that is likely unnecessary			(ds
> mythies)
> o Rebase on top of linux-pm/linux-next
> 
> The PID relies on samples of equal time but this does not apply for
> deferrable timers when the CPU is idle. intel_pstate checks if the
> actual
> duration between samples is large and if so, the "busyness" of the
> CPU
> is scaled.
> 
> This assumes the delay was a deferred timer but a workload may simply
> have
> been idle for a short time if it's context switching between a server
> and
> client or waiting very briefly on IO. It's compounded by the problem
> that
> server/clients migrate between CPUs due to wake-affine trying to
> maximise
> hot cache usage. In such cases, the cores are not considered busy and
> the
> frequency is dropped prematurely.
> 
> This patch increases the hold-off value before the busyness is
> scaled. It
> was selected based simply on testing until the desired result was
> found.
> Tests were conducted with workloads that are either client/server
> based
> or short-lived IO.

Attached specpower comparison for Haswell EP Grantley server. 

This workload ran about an hour+.

Difference in OPS:
+1019
Difference in power:
+308.6
Difference in perf/watt -312.479023

So we are consuming 308 Watts on average for doing 1019 operation more.

Thanks,
Srinivas



[-- Attachment #2: HSW Grantley (hswep) spec_power (02_23_16).pdf --]
[-- Type: application/pdf, Size: 36086 bytes --]

  parent reply	other threads:[~2016-02-23 21:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23 14:29 [PATCH 1/1] intel_pstate: Increase hold-off time before samples are scaled v2 Mel Gorman
2016-02-23 14:48 ` kbuild test robot
2016-02-23 21:50 ` Srinivas Pandruvada [this message]
2016-02-24  9:03   ` Mel Gorman
2016-02-24 13:33     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456264234.8680.155.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=dirk.j.brandewie@intel.com \
    --cc=dsmythies@telus.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=stephane.gasparini@linux.intel.com \
    --cc=umgwanakikbuti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).