linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: acpi_cpufreq: base frequency attribute support
Date: Wed, 24 Feb 2016 15:37:53 -0800	[thread overview]
Message-ID: <1456357073.3860.21.camel@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0hh20C3vgWfBpRmR+oOjOf7kqP6HMLKjqzYx8h0ka_dVQ@mail.gmail.com>

On Wed, 2016-02-24 at 21:05 +0100, Rafael J. Wysocki wrote:
> On Wed, Feb 24, 2016 at 9:00 PM, Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com> wrote:
> > On Fri, 2015-10-16 at 11:12 +0530, Viresh Kumar wrote:
> > > On 16-10-15, 00:45, Rafael J. Wysocki wrote:
> > > > We're talking about a continuous range above the base frequency
> > > > here.
> > > 
> > > Ick. No it can't be reused for the continuous range stuff.
> > > 
> > I know this is bit old discussion. Is there any problem in applying
> > this patch?
> 
> Not in principle, but can you please resubmit?
> 
Good I tested again.

Hi Viresh,

Are we no longer allowed to call
	sysfs_create_file in cpufreq_driver.init() callback?

The following call crashes because of BUG_ON for !kobj->sd:
	sysfs_create_file(&policy->kobj,
                                  &(cpufreq_attr_base_frequency.attr));

Before I debug further, I want to check with you.
This used to work before.

Thanks,
Srinivas

> Thanks,
> Rafael
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-02-24 23:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-01 22:25 [PATCH] cpufreq: acpi_cpufreq: base frequency attribute support Srinivas Pandruvada
2015-10-07 17:23 ` Viresh Kumar
2015-10-09 15:34   ` Srinivas Pandruvada
2015-10-15 22:45   ` Rafael J. Wysocki
2015-10-16  5:42     ` Viresh Kumar
2016-02-24 20:00       ` Srinivas Pandruvada
2016-02-24 20:05         ` Rafael J. Wysocki
2016-02-24 23:37           ` Srinivas Pandruvada [this message]
2016-02-25  3:27             ` Viresh Kumar
2016-02-25 18:07               ` Srinivas Pandruvada
2016-02-26  1:10                 ` Pandruvada, Srinivas
2016-02-26  1:57                 ` Viresh Kumar
2016-02-26 20:21                   ` Srinivas Pandruvada
2016-02-29  3:16                     ` Viresh Kumar
2016-02-29 17:11                       ` Srinivas Pandruvada
2016-03-01  2:16                         ` Viresh Kumar
  -- strict thread matches above, loose matches on Subject: below --
2016-02-29 20:36 Srinivas Pandruvada
2016-03-01  2:28 ` Viresh Kumar
2016-03-01 18:10   ` Srinivas Pandruvada
2016-03-02  2:38     ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456357073.3860.21.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).