From: Leo Yan <leo.yan@linaro.org>
To: Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
kongxinwei <kong.kongxinwei@hisilicon.com>,
Javi Merino <javi.merino@arm.com>,
Punit Agrawal <Punit.Agrawal@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Leo Yan <leo.yan@linaro.org>
Subject: [PATCH v2 1/5] thermal: change "hysteresis" as optional property
Date: Fri, 26 Feb 2016 11:43:43 +0800 [thread overview]
Message-ID: <1456458227-12950-2-git-send-email-leo.yan@linaro.org> (raw)
In-Reply-To: <1456458227-12950-1-git-send-email-leo.yan@linaro.org>
The property "hysteresis" is mandatory for trip points, so if without
it the thermal zone cannot register successfully. But "hysteresis" is
ignored in the thermal subsystem and only inquired by several thermal
sensor drivers.
So change "hysteresis" as optional properties.
Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
Documentation/devicetree/bindings/thermal/thermal.txt | 9 +++++----
drivers/thermal/of-thermal.c | 9 ++++-----
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
index 41b817f..7d79e77 100644
--- a/Documentation/devicetree/bindings/thermal/thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/thermal.txt
@@ -89,10 +89,6 @@ Required properties:
Type: signed in millicelsius.
Size: one cell
-- hysteresis: A low hysteresis value on temperature property (above).
- Type: unsigned This is a relative value, in millicelsius.
- Size: one cell
-
- type: a string containing the trip type. Expected values are:
"active": A trip point to enable active cooling
"passive": A trip point to enable passive cooling
@@ -100,6 +96,11 @@ Required properties:
"critical": Hardware not reliable.
Type: string
+Optional properties:
+- hysteresis: A low hysteresis value on temperature property (above).
+ Type: unsigned This is a relative value, in millicelsius.
+ Size: one cell
+
* Cooling device maps
The cooling device maps node is a node to describe how cooling devices
diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
index 9043f8f..ab05500 100644
--- a/drivers/thermal/of-thermal.c
+++ b/drivers/thermal/of-thermal.c
@@ -689,11 +689,10 @@ static int thermal_of_populate_trip(struct device_node *np,
trip->temperature = prop;
ret = of_property_read_u32(np, "hysteresis", &prop);
- if (ret < 0) {
- pr_err("missing hysteresis property\n");
- return ret;
- }
- trip->hysteresis = prop;
+ if (ret < 0)
+ pr_warning("missing hysteresis property\n");
+ else
+ trip->hysteresis = prop;
ret = thermal_of_get_trip_type(np, &trip->type);
if (ret < 0) {
--
1.9.1
next prev parent reply other threads:[~2016-02-26 3:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 3:43 [PATCH v2 0/5] thermal: hisilicon: enable power allocator for Hi6220 Leo Yan
2016-02-26 3:43 ` Leo Yan [this message]
[not found] ` <1456458227-12950-2-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-03 10:45 ` [PATCH v2 1/5] thermal: change "hysteresis" as optional property Javi Merino
2016-03-03 16:29 ` Eduardo Valentin
2016-03-04 3:03 ` Leo Yan
2016-03-04 11:57 ` Javi Merino
2016-03-08 13:57 ` Leo Yan
2016-03-08 20:55 ` Eduardo Valentin
2016-03-09 11:10 ` Javi Merino
2016-03-20 15:40 ` Leo Yan
2016-02-26 3:43 ` [PATCH v2 2/5] thermal: hisilicon: support to use any sensor Leo Yan
2016-02-26 3:43 ` [PATCH v2 3/5] thermal: hisilicon: fix IRQ imbalance enabling Leo Yan
2016-02-26 3:43 ` [PATCH v2 4/5] arm64: dts: register Hi6220's thermal sensor Leo Yan
2016-02-26 3:43 ` [PATCH v2 5/5] arm64: dts: register Hi6220's thermal zone for power allocator Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456458227-12950-2-git-send-email-leo.yan@linaro.org \
--to=leo.yan@linaro.org \
--cc=Punit.Agrawal@arm.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javi.merino@arm.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).