答复: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

Hongtao Jia
2016-01-11T14:54:14Z

Sorry for the late response. I got a knee surgery to do.
See comments at the end.

> -----邮件原件-----
> 发件人: Arnd Bergmann [mailto:arnd@arndb.de]
> 发送时间: Saturday, December 19, 2015 6:33 AM
> 收件人: Rafael J. Wysocki <rjw@rjwysocki.net>
> 抄送: Jia Hongtao <hongtao.jia@freescale.com>; edubezval@gmail.com;
> viresh.kumar@linaro.org; linux-pm@vger.kernel.org; linuxppc-
> dev@lists.ozlabs.org; devicetree@vger.kernel.org; Scott Wood
> <scottwood@freescale.com>
> 主题: Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device
> tree
>
> On Tuesday 15 December 2015 00:58:26 Rafael J. Wysocki wrote:
> > On Thursday, November 26, 2015 05:21:11 PM Jia Hongtao wrote:
> > > Register the qoriq cpufreq driver as a cooling device, based on the
> > > thermal device tree framework. When temperature crosses the passive
> > > trip point cpufreq is used to throttle CPUs.
> > >
> > > Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
> > > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > Applied, thanks!
> >
>
> I got a randconfig build error today:
>
> drivers/built-in.o: In function `qoriq_cpufreq_ready':
> debugfs.c:(.text+0x1f4688): undefined reference to
> `of_cpufreq_cooling_register'
>
> CONFIG_OF=y
> CONFIG_QORIQ_CPUFREQ=y
> CONFIG_THERMAL=m
> CONFIG_THERMAL_OF=y
>
> I think you need a 'depends on THERMAL' to prevent the driver from being
> built-in when THERMAL=m.
>
> Arnd

Correct. I need to add following lines to the Kconfig file:
depends on !CPU_THERMAL || THERMAL=y

Hi Rafael,
Should I send a new patch include this fix or send a fix patch?

Thanks.
-Hongtao.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org