From: Oliver Neukum <oneukum@suse.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "David S. Miller" <davem@davemloft.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Woojung Huh <woojung.huh@microchip.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM
Date: Tue, 22 Mar 2016 15:28:23 +0100 [thread overview]
Message-ID: <1458656903.1990.12.camel@suse.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1603221014500.1793-100000@iolanthe.rowland.org>
On Tue, 2016-03-22 at 10:21 -0400, Alan Stern wrote:
> I don't see any point in resuming the device just in order to collect
> operating statistics. If it was already suspended then it wasn't
> operating, so there will be no statistics to collect.
Indeed. In that case the point is moot. But it is correct to ask
the core whether the device is autosuspended at that point rather
than keep a private flag if you can.
All that is relevant only if the upper layers ask for information
that the driver cannot provide without resuming the device.
Those are fundamentally different issues.
Regards
Oliver
next prev parent reply other threads:[~2016-03-22 14:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 10:43 [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Geert Uytterhoeven
2016-03-20 16:35 ` Eric Dumazet
2016-03-20 20:52 ` David Miller
2016-03-20 22:59 ` Guenter Roeck
2016-03-21 14:59 ` Woojung.Huh
2016-03-21 8:36 ` Oliver Neukum
[not found] ` <1458549361.2299.1.camel-IBi9RG/b67k@public.gmane.org>
2016-03-21 14:41 ` Woojung.Huh-UWL1GkI3JZL3oGB3hsPCZA
2016-03-21 14:57 ` Alan Stern
2016-03-21 17:34 ` Oliver Neukum
2016-03-21 18:24 ` Alan Stern
2016-03-21 18:42 ` Woojung.Huh
2016-03-21 19:27 ` Alan Stern
2016-03-21 20:09 ` Woojung.Huh
[not found] ` <9235D6609DB808459E95D78E17F2E43D404CC1EF-8fD0d2gESGrABDY0R+s2SH2Vsf1/G1/XQQ4Iyu8u01E@public.gmane.org>
2016-03-21 21:02 ` Alan Stern
2016-03-21 18:51 ` Oliver Neukum
2016-03-21 19:30 ` Alan Stern
2016-03-22 9:50 ` Oliver Neukum
[not found] ` <1458640209.1990.8.camel-IBi9RG/b67k@public.gmane.org>
2016-03-22 14:21 ` Alan Stern
2016-03-22 14:28 ` Oliver Neukum [this message]
2016-03-22 15:13 ` Alan Stern
2016-03-22 15:29 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458656903.1990.12.camel@suse.com \
--to=oneukum@suse.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).