* cppc_cpufreq
@ 2016-04-07 23:50 Pandruvada, Srinivas
2016-04-08 15:08 ` cppc_cpufreq Ashwin Chaugule
0 siblings, 1 reply; 5+ messages in thread
From: Pandruvada, Srinivas @ 2016-04-07 23:50 UTC (permalink / raw)
To: ashwin.chaugule@linaro.org
Cc: viresh.kumar@linaro.org, linux-pm@vger.kernel.org,
rjw@rjwysocki.net
Hi Ashwin,
I didn't see in the cppc_cpufreq.c
MODULE_LICENSE()
Is it intentional?
Thanks,
Srinivas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: cppc_cpufreq
2016-04-07 23:50 cppc_cpufreq Pandruvada, Srinivas
@ 2016-04-08 15:08 ` Ashwin Chaugule
2016-04-09 21:28 ` cppc_cpufreq Srinivas Pandruvada
0 siblings, 1 reply; 5+ messages in thread
From: Ashwin Chaugule @ 2016-04-08 15:08 UTC (permalink / raw)
To: Pandruvada, Srinivas
Cc: viresh.kumar@linaro.org, linux-pm@vger.kernel.org,
rjw@rjwysocki.net
On 7 April 2016 at 19:50, Pandruvada, Srinivas
<srinivas.pandruvada@intel.com> wrote:
> Hi Ashwin,
>
> I didn't see in the cppc_cpufreq.c
>
> MODULE_LICENSE()
>
> Is it intentional?
Not intentional. Doesn't the absence of this default to GPLv2? or is
it required that the license be explicitly stated?
Thanks,
Ashwin.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: cppc_cpufreq
2016-04-08 15:08 ` cppc_cpufreq Ashwin Chaugule
@ 2016-04-09 21:28 ` Srinivas Pandruvada
2016-04-11 14:53 ` cppc_cpufreq Ashwin Chaugule
0 siblings, 1 reply; 5+ messages in thread
From: Srinivas Pandruvada @ 2016-04-09 21:28 UTC (permalink / raw)
To: Ashwin Chaugule
Cc: viresh.kumar@linaro.org, linux-pm@vger.kernel.org,
rjw@rjwysocki.net
On Fri, 2016-04-08 at 11:08 -0400, Ashwin Chaugule wrote:
> On 7 April 2016 at 19:50, Pandruvada, Srinivas
> <srinivas.pandruvada@intel.com> wrote:
> > Hi Ashwin,
> >
> > I didn't see in the cppc_cpufreq.c
> >
> > MODULE_LICENSE()
> >
> > Is it intentional?
>
> Not intentional. Doesn't the absence of this default to GPLv2? or is
> it required that the license be explicitly stated?
>
You are using symbols exported using EXPORT_SYMBOL_GPL
I get following error during insmod:
[ 33.400861] cppc_cpufreq: module verification failed: signature
and/or required key missing - tainting kernel
[ 33.400890] cppc_cpufreq: Unknown symbol cpufreq_register_driver
(err 0)
[ 33.400901] cppc_cpufreq: Unknown symbol cppc_get_perf_ctrs (err 0)
[ 33.400914] cppc_cpufreq: Unknown symbol acpi_get_psd_map (err 0)
[ 33.400924] cppc_cpufreq: Unknown symbol cpufreq_freq_transition_end
(err 0)
[ 33.400935] cppc_cpufreq: Unknown symbol cppc_get_perf_caps (err 0)
[ 33.400945] cppc_cpufreq: Unknown symbol
cpufreq_freq_transition_begin (err 0)
[ 33.400954] cppc_cpufreq: Unknown symbol cppc_set_perf (err 0)
I had to add MODULE_LICENSE(GPL).
Thanks,
Srinivas
>
> Thanks,
> Ashwin.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: cppc_cpufreq
2016-04-09 21:28 ` cppc_cpufreq Srinivas Pandruvada
@ 2016-04-11 14:53 ` Ashwin Chaugule
2016-04-11 16:05 ` cppc_cpufreq Srinivas Pandruvada
0 siblings, 1 reply; 5+ messages in thread
From: Ashwin Chaugule @ 2016-04-11 14:53 UTC (permalink / raw)
To: Srinivas Pandruvada
Cc: viresh.kumar@linaro.org, linux-pm@vger.kernel.org,
rjw@rjwysocki.net
On 9 April 2016 at 17:28, Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
> On Fri, 2016-04-08 at 11:08 -0400, Ashwin Chaugule wrote:
>> On 7 April 2016 at 19:50, Pandruvada, Srinivas
>> <srinivas.pandruvada@intel.com> wrote:
>> > Hi Ashwin,
>> >
>> > I didn't see in the cppc_cpufreq.c
>> >
>> > MODULE_LICENSE()
>> >
>> > Is it intentional?
>>
>> Not intentional. Doesn't the absence of this default to GPLv2? or is
>> it required that the license be explicitly stated?
>>
> You are using symbols exported using EXPORT_SYMBOL_GPL
>
> I get following error during insmod:
>
> [ 33.400861] cppc_cpufreq: module verification failed: signature
> and/or required key missing - tainting kernel
> [ 33.400890] cppc_cpufreq: Unknown symbol cpufreq_register_driver
> (err 0)
> [ 33.400901] cppc_cpufreq: Unknown symbol cppc_get_perf_ctrs (err 0)
> [ 33.400914] cppc_cpufreq: Unknown symbol acpi_get_psd_map (err 0)
> [ 33.400924] cppc_cpufreq: Unknown symbol cpufreq_freq_transition_end
> (err 0)
> [ 33.400935] cppc_cpufreq: Unknown symbol cppc_get_perf_caps (err 0)
> [ 33.400945] cppc_cpufreq: Unknown symbol
> cpufreq_freq_transition_begin (err 0)
> [ 33.400954] cppc_cpufreq: Unknown symbol cppc_set_perf (err 0)
>
> I had to add MODULE_LICENSE(GPL).
Ok. Thanks for the heads up. Will post a patch soon, unless you want
to go ahead and send yours out.
Thanks,
Ashwin.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: cppc_cpufreq
2016-04-11 14:53 ` cppc_cpufreq Ashwin Chaugule
@ 2016-04-11 16:05 ` Srinivas Pandruvada
0 siblings, 0 replies; 5+ messages in thread
From: Srinivas Pandruvada @ 2016-04-11 16:05 UTC (permalink / raw)
To: Ashwin Chaugule
Cc: viresh.kumar@linaro.org, linux-pm@vger.kernel.org,
rjw@rjwysocki.net
On Mon, 2016-04-11 at 10:53 -0400, Ashwin Chaugule wrote:
> On 9 April 2016 at 17:28, Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com> wrote:
> > On Fri, 2016-04-08 at 11:08 -0400, Ashwin Chaugule wrote:
> > > On 7 April 2016 at 19:50, Pandruvada, Srinivas
> > > <srinivas.pandruvada@intel.com> wrote:
> > > > Hi Ashwin,
> > > >
> > > > I didn't see in the cppc_cpufreq.c
> > > >
> > > > MODULE_LICENSE()
> > > >
> > > > Is it intentional?
> > >
> > > Not intentional. Doesn't the absence of this default to GPLv2? or
> > > is
> > > it required that the license be explicitly stated?
> > >
> > You are using symbols exported using EXPORT_SYMBOL_GPL
> >
> > I get following error during insmod:
> >
> > [ 33.400861] cppc_cpufreq: module verification failed: signature
> > and/or required key missing - tainting kernel
> > [ 33.400890] cppc_cpufreq: Unknown symbol cpufreq_register_driver
> > (err 0)
> > [ 33.400901] cppc_cpufreq: Unknown symbol cppc_get_perf_ctrs (err
> > 0)
> > [ 33.400914] cppc_cpufreq: Unknown symbol acpi_get_psd_map (err
> > 0)
> > [ 33.400924] cppc_cpufreq: Unknown symbol
> > cpufreq_freq_transition_end
> > (err 0)
> > [ 33.400935] cppc_cpufreq: Unknown symbol cppc_get_perf_caps (err
> > 0)
> > [ 33.400945] cppc_cpufreq: Unknown symbol
> > cpufreq_freq_transition_begin (err 0)
> > [ 33.400954] cppc_cpufreq: Unknown symbol cppc_set_perf (err 0)
> >
> > I had to add MODULE_LICENSE(GPL).
>
> Ok. Thanks for the heads up. Will post a patch soon, unless you want
> to go ahead and send yours out.
This is license, so I prefer you post.
I will post other changes to CPPC for x86 once I am ready.
Thanks,
Srinivas
>
> Thanks,
> Ashwin.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-11 16:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-07 23:50 cppc_cpufreq Pandruvada, Srinivas
2016-04-08 15:08 ` cppc_cpufreq Ashwin Chaugule
2016-04-09 21:28 ` cppc_cpufreq Srinivas Pandruvada
2016-04-11 14:53 ` cppc_cpufreq Ashwin Chaugule
2016-04-11 16:05 ` cppc_cpufreq Srinivas Pandruvada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).