linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	Eduardo Valentin <edubezval@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Rui Zhang <rui.zhang@intel.com>,
	Linux PM <linux-pm@vger.kernel.org>, Len Brown <lenb@kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] drivers: acpi: add CPU id to cooling device type of processor driver
Date: Wed, 04 May 2016 14:54:32 -0700	[thread overview]
Message-ID: <1462398872.14904.29.camel@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0hPL3Wc1ZKZv-Gqny5cur9+262OCuqVqbQ2US9=gpsX7g@mail.gmail.com>

On Wed, 2016-05-04 at 23:49 +0200, Rafael J. Wysocki wrote:
> On Tue, May 3, 2016 at 7:04 AM, Eduardo Valentin <edubezval@gmail.com
> > wrote:
> > 
> > Currently, in an ACPI based system, the processor driver registers
> > one cooling device per processor. However, the cooling device type
> > is the same for each processor. For example, on a system with four
> > processors, the sysfs reading of each cooling device would look
> > like:
> > ebv@besouro ~ $ cat /sys/class/thermal/cooling_device*/type
> > Processor
> > Processor
> > Processor
> > Processor
> > 
> > which turns out to fine. But, some parts of the thermal code may
> > use
> > type to identify participating devices in a thermal zone. Besides,
> > adding notifications to user space may cause the production of
> > messages
> > that may confuse the listener.
> > 
> > For this reason, this patch adds the processor ID cooling device
> > type.
> > After this change, the cooling device listing in the same previous
> > example
> > would look like this:
> > ebv@besouro ~ $ cat /sys/class/thermal/cooling_device*/type
> > Processor.0
> > Processor.1
> > Processor.2
> > Processor.3
> > 
> > allowing an easier identification of cooling device target.
> Is it not going to confuse any user space scripts or similar?
Yes, it will.

Thanks,
Srinivas





  reply	other threads:[~2016-05-04 21:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03  5:04 [PATCH 1/1] drivers: acpi: add CPU id to cooling device type of processor driver Eduardo Valentin
2016-05-04 21:49 ` Rafael J. Wysocki
2016-05-04 21:54   ` Srinivas Pandruvada [this message]
2016-05-04 22:00     ` Rafael J. Wysocki
2016-05-05  3:06       ` Eduardo Valentin
2016-05-05 18:27         ` Srinivas Pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462398872.14904.29.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=edubezval@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).