* [PATCH] intel_pstate: Clean up intel_pstate_get()
@ 2016-05-07 0:24 Rafael J. Wysocki
2016-05-09 19:22 ` Srinivas Pandruvada
0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2016-05-07 0:24 UTC (permalink / raw)
To: Linux PM list; +Cc: Linux Kernel Mailing List, Srinivas Pandruvada
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
intel_pstate_get() contains a local variable that's initialized but
never used and it can be written in fewer lines of code, so clean
it up.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/cpufreq/intel_pstate.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
Index: linux-pm/drivers/cpufreq/intel_pstate.c
===================================================================
--- linux-pm.orig/drivers/cpufreq/intel_pstate.c
+++ linux-pm/drivers/cpufreq/intel_pstate.c
@@ -1390,14 +1390,9 @@ static int intel_pstate_init_cpu(unsigne
static unsigned int intel_pstate_get(unsigned int cpu_num)
{
- struct sample *sample;
- struct cpudata *cpu;
+ struct cpudata *cpu = all_cpu_data[cpu_num];
- cpu = all_cpu_data[cpu_num];
- if (!cpu)
- return 0;
- sample = &cpu->sample;
- return get_avg_frequency(cpu);
+ return cpu ? get_avg_frequency(cpu) : 0;
}
static void intel_pstate_set_update_util_hook(unsigned int cpu_num)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] intel_pstate: Clean up intel_pstate_get()
2016-05-07 0:24 [PATCH] intel_pstate: Clean up intel_pstate_get() Rafael J. Wysocki
@ 2016-05-09 19:22 ` Srinivas Pandruvada
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Pandruvada @ 2016-05-09 19:22 UTC (permalink / raw)
To: Rafael J. Wysocki, Linux PM list; +Cc: Linux Kernel Mailing List
On Sat, 2016-05-07 at 02:24 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> intel_pstate_get() contains a local variable that's initialized but
> never used and it can be written in fewer lines of code, so clean
> it up.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/cpufreq/intel_pstate.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> Index: linux-pm/drivers/cpufreq/intel_pstate.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/intel_pstate.c
> +++ linux-pm/drivers/cpufreq/intel_pstate.c
> @@ -1390,14 +1390,9 @@ static int intel_pstate_init_cpu(unsigne
>
> static unsigned int intel_pstate_get(unsigned int cpu_num)
> {
> - struct sample *sample;
> - struct cpudata *cpu;
> + struct cpudata *cpu = all_cpu_data[cpu_num];
>
> - cpu = all_cpu_data[cpu_num];
> - if (!cpu)
> - return 0;
> - sample = &cpu->sample;
> - return get_avg_frequency(cpu);
> + return cpu ? get_avg_frequency(cpu) : 0;
> }
>
> static void intel_pstate_set_update_util_hook(unsigned int cpu_num)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-09 19:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-07 0:24 [PATCH] intel_pstate: Clean up intel_pstate_get() Rafael J. Wysocki
2016-05-09 19:22 ` Srinivas Pandruvada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).