linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Linda Knippers <linda.knippers@hpe.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: Enforce _PPC limits
Date: Wed, 25 May 2016 10:01:29 -0700	[thread overview]
Message-ID: <1464195689.26461.63.camel@linux.intel.com> (raw)
In-Reply-To: <cef22f9e-d60e-2065-e8a6-74c43e9b78f7@hpe.com>

Hi Linda,

[...]

> I guess I've lost track of what intel_pstate is doing these
> days.  When it
> first came out, it totally disregarded ACPI information, which is why
> code
> was added to not load the driver on some platforms that are doing
> their
> own power management.  The rationale for not using ACPI was that ACPI
> couldn't express all the information necessary to describe the
> hardware
> capabilities.
> 
> Now it is using ACPI information for some things, but not all things?
> Perhaps intel_pstate.txt could be updated to clarify that?
>  Depending
> on what the future is for intel_pstate and ACPI, I'm wondering if
> that
> vendor-specific code is no longer needed.
> 
> This might be a nit but I'm also confused about whether it's really
> enforcing _PPC limits or _PSS.  Are you actually limiting based on
> the _PPC value?
_PPC is an index into _PSS, the max frequency we will get from _PSS. We
are not enforcing any limits in _PSS. So if some P-State is missing in
_PSS, we will still select that P-State.
I don't know what vendor specific code does. I guess it does more than
just what acpi-cpufreq would have done.

I will check on the documentation part.

Thanks,
Srinivas



  reply	other threads:[~2016-05-25 17:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24 20:37 Enforce _PPC limits Linda Knippers
2016-05-24 22:11 ` Srinivas Pandruvada
2016-05-25 16:36   ` Linda Knippers
2016-05-25 17:01     ` Srinivas Pandruvada [this message]
2016-05-25 17:18       ` Linda Knippers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464195689.26461.63.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=linda.knippers@hpe.com \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).