* [PATCH] power/reset: make syscon_poweroff() static
@ 2016-06-08 18:28 Ben Dooks
2016-06-09 10:24 ` Krzysztof Kozłowski
2016-06-10 1:54 ` Sebastian Reichel
0 siblings, 2 replies; 3+ messages in thread
From: Ben Dooks @ 2016-06-08 18:28 UTC (permalink / raw)
To: linux-kernel
Cc: Ben Dooks, Sebastian Reichel, Dmitry Eremin-Solenikov,
David Woodhouse, linux-pm
The syscon_poweroff() function is not exported or declared for
usage elsewhere, so make it static to avoid the folloiwing warning:
drivers/power/reset/syscon-poweroff.c:33:6: warning: symbol 'syscon_poweroff' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: linux-pm@vger.kernel.org
---
drivers/power/reset/syscon-poweroff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/reset/syscon-poweroff.c b/drivers/power/reset/syscon-poweroff.c
index 5560b0d..b683383 100644
--- a/drivers/power/reset/syscon-poweroff.c
+++ b/drivers/power/reset/syscon-poweroff.c
@@ -30,7 +30,7 @@ static struct regmap *map;
static u32 offset;
static u32 mask;
-void syscon_poweroff(void)
+static void syscon_poweroff(void)
{
/* Issue the poweroff */
regmap_write(map, offset, mask);
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] power/reset: make syscon_poweroff() static
2016-06-08 18:28 [PATCH] power/reset: make syscon_poweroff() static Ben Dooks
@ 2016-06-09 10:24 ` Krzysztof Kozłowski
2016-06-10 1:54 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozłowski @ 2016-06-09 10:24 UTC (permalink / raw)
To: Ben Dooks
Cc: linux-kernel, Sebastian Reichel, Dmitry Eremin-Solenikov,
David Woodhouse, linux-pm
On Wed, Jun 8, 2016 at 8:28 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> The syscon_poweroff() function is not exported or declared for
> usage elsewhere, so make it static to avoid the folloiwing warning:
>
> drivers/power/reset/syscon-poweroff.c:33:6: warning: symbol 'syscon_poweroff' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: linux-pm@vger.kernel.org
> ---
> drivers/power/reset/syscon-poweroff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power/reset: make syscon_poweroff() static
2016-06-08 18:28 [PATCH] power/reset: make syscon_poweroff() static Ben Dooks
2016-06-09 10:24 ` Krzysztof Kozłowski
@ 2016-06-10 1:54 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2016-06-10 1:54 UTC (permalink / raw)
To: Ben Dooks
Cc: linux-kernel, Dmitry Eremin-Solenikov, David Woodhouse, linux-pm
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
Hi,
On Wed, Jun 08, 2016 at 07:28:54PM +0100, Ben Dooks wrote:
> The syscon_poweroff() function is not exported or declared for
> usage elsewhere, so make it static to avoid the folloiwing warning:
>
> drivers/power/reset/syscon-poweroff.c:33:6: warning: symbol 'syscon_poweroff' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-10 1:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-08 18:28 [PATCH] power/reset: make syscon_poweroff() static Ben Dooks
2016-06-09 10:24 ` Krzysztof Kozłowski
2016-06-10 1:54 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).