From: "Jon Medhurst (Tixy)" <tixy@linaro.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: Re: [PATCH v2 0/3] firmware: scpi: add device power domain support
Date: Thu, 16 Jun 2016 14:14:54 +0100 [thread overview]
Message-ID: <1466082894.20208.1.camel@linaro.org> (raw)
In-Reply-To: <1466073481-697-1-git-send-email-sudeep.holla@arm.com>
On Thu, 2016-06-16 at 11:37 +0100, Sudeep Holla wrote:
> This series add support for SCPI based device device power state
> management using genpd.
>
> Regards,
> Sudeep
>
> v1[1]->v2:
> - Fixed the endianness handling in scpi_device_get_power_state
> as spotted by Tixy
> - Renamed scpi_pd.c to scpi_pm_domain.c as suggested by Ulf
You seemed to also have made some changes to the contents of the file,
is that deliberate? This is the diff...
--- a/drivers/firmware/scpi_pm_domain.c
+++ b/drivers/firmware/scpi_pd.c
@@ -27,7 +27,7 @@ struct scpi_pm_domain {
struct generic_pm_domain genpd;
struct scpi_ops *ops;
u32 domain;
- char name[20];
+ char name[30];
};
enum scpi_power_domain_state {
@@ -51,7 +51,7 @@ static int scpi_pd_power(struct scpi_pm_domain *pd,
bool power_on)
if (ret)
return ret;
- return (state == pd->ops->device_get_power_state(pd->domain));
+ return !(state == pd->ops->device_get_power_state(pd->domain));
}
static int scpi_pd_power_on(struct generic_pm_domain *domain)
next prev parent reply other threads:[~2016-06-16 13:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 10:37 [PATCH v2 0/3] firmware: scpi: add device power domain support Sudeep Holla
2016-06-16 10:37 ` [PATCH v2 1/3] firmware: arm_scpi: add support for device power state management Sudeep Holla
2016-06-16 18:03 ` Jon Medhurst (Tixy)
2016-06-17 8:46 ` Sudeep Holla
2016-06-16 10:38 ` [PATCH v2 2/3] Documentation: add DT bindings for ARM SCPI power domains Sudeep Holla
2016-06-16 10:38 ` [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd Sudeep Holla
2016-06-16 17:47 ` Jon Medhurst (Tixy)
2016-06-16 17:59 ` Sudeep Holla
2016-06-17 8:19 ` Jon Medhurst (Tixy)
2016-06-17 8:38 ` Sudeep Holla
2016-06-20 17:50 ` Kevin Hilman
2016-06-20 17:57 ` Sudeep Holla
2016-06-17 8:55 ` Sudeep Holla
2016-06-17 8:55 ` Sudeep Holla
2016-06-20 17:53 ` Kevin Hilman
2016-06-20 18:06 ` Sudeep Holla
2016-06-16 13:14 ` Jon Medhurst (Tixy) [this message]
2016-06-16 13:26 ` [PATCH v2 0/3] firmware: scpi: add device power domain support Sudeep Holla
2016-06-17 8:56 ` Ulf Hansson
2016-06-17 15:22 ` Mathieu Poirier
2016-06-17 15:34 ` Sudeep Holla
2016-06-20 17:56 ` Kevin Hilman
2016-06-20 18:02 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466082894.20208.1.camel@linaro.org \
--to=tixy@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).