From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Jisheng Zhang <jszhang@marvell.com>,
lenb@kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] intel_pstate: add __init/__initdata marker to some functions/variables
Date: Mon, 27 Jun 2016 10:26:57 -0700 [thread overview]
Message-ID: <1467048417.8970.80.camel@linux.intel.com> (raw)
In-Reply-To: <1467022038-924-3-git-send-email-jszhang@marvell.com>
On Mon, 2016-06-27 at 18:07 +0800, Jisheng Zhang wrote:
> These functions/variables are not needed after booting, so mark them
> as __init or __initdata.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/cpufreq/intel_pstate.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c
> b/drivers/cpufreq/intel_pstate.c
> index 44099e9..861bcba 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1355,7 +1355,7 @@ static const struct x86_cpu_id
> intel_pstate_cpu_ids[] = {
> };
> MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
>
> -static const struct x86_cpu_id intel_pstate_cpu_oob_ids[] = {
> +static const struct x86_cpu_id intel_pstate_cpu_oob_ids[]
> __initconst = {
> ICPU(0x56, core_params),
> {}
> };
> @@ -1577,9 +1577,9 @@ static struct cpufreq_driver
> intel_pstate_driver = {
> static int no_load __initdata;
> static int no_hwp __initdata;
> static int hwp_only __initdata;
> -static unsigned int force_load;
> +static unsigned int force_load __initdata;
>
> -static int intel_pstate_msrs_not_valid(void)
> +static int __init intel_pstate_msrs_not_valid(void)
> {
> if (!pstate_funcs.get_max() ||
> !pstate_funcs.get_min() ||
> @@ -1589,7 +1589,7 @@ static int intel_pstate_msrs_not_valid(void)
> return 0;
> }
>
> -static void copy_pid_params(struct pstate_adjust_policy *policy)
> +static void __init copy_pid_params(struct pstate_adjust_policy
> *policy)
> {
> pid_params.sample_rate_ms = policy->sample_rate_ms;
> pid_params.sample_rate_ns = pid_params.sample_rate_ms *
> NSEC_PER_MSEC;
> @@ -1600,7 +1600,7 @@ static void copy_pid_params(struct
> pstate_adjust_policy *policy)
> pid_params.setpoint = policy->setpoint;
> }
>
> -static void copy_cpu_funcs(struct pstate_funcs *funcs)
> +static void __init copy_cpu_funcs(struct pstate_funcs *funcs)
> {
> pstate_funcs.get_max = funcs->get_max;
> pstate_funcs.get_max_physical = funcs->get_max_physical;
> @@ -1615,7 +1615,7 @@ static void copy_cpu_funcs(struct pstate_funcs
> *funcs)
>
> #ifdef CONFIG_ACPI
>
> -static bool intel_pstate_no_acpi_pss(void)
> +static bool __init intel_pstate_no_acpi_pss(void)
> {
> int i;
>
> @@ -1644,7 +1644,7 @@ static bool intel_pstate_no_acpi_pss(void)
> return true;
> }
>
> -static bool intel_pstate_has_acpi_ppc(void)
> +static bool __init intel_pstate_has_acpi_ppc(void)
> {
> int i;
>
> @@ -1672,7 +1672,7 @@ struct hw_vendor_info {
> };
>
> /* Hardware vendor-specific info that has its own power management
> modes */
> -static struct hw_vendor_info vendor_info[] = {
> +static struct hw_vendor_info vendor_info[] __initdata = {
> {1, "HP ", "ProLiant", PSS},
> {1, "ORACLE", "X4-2 ", PPC},
> {1, "ORACLE", "X4-2L ", PPC},
> @@ -1691,7 +1691,7 @@ static struct hw_vendor_info vendor_info[] = {
> {0, "", ""},
> };
>
> -static bool intel_pstate_platform_pwr_mgmt_exists(void)
> +static bool __init intel_pstate_platform_pwr_mgmt_exists(void)
> {
> struct acpi_table_header hdr;
> struct hw_vendor_info *v_info;
next prev parent reply other threads:[~2016-06-27 17:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 10:07 [PATCH v2 0/3] cpufreq: intel_pstate: trivial improvements Jisheng Zhang
2016-06-27 10:07 ` [PATCH v2 1/3] intel_pstate: Fix incorrect placement of __initdata Jisheng Zhang
2016-06-27 17:19 ` Srinivas Pandruvada
2016-06-27 10:07 ` [PATCH v2 2/3] intel_pstate: add __init/__initdata marker to some functions/variables Jisheng Zhang
2016-06-27 17:26 ` Srinivas Pandruvada [this message]
2016-06-27 10:07 ` [PATCH v2 3/3] intel_pstate: Declare pid_params/pstate_funcs/hwp_active __read_mostly Jisheng Zhang
2016-06-27 17:29 ` Srinivas Pandruvada
2016-06-28 2:29 ` Jisheng Zhang
2016-06-28 11:43 ` Rafael J. Wysocki
2016-07-04 13:03 ` [PATCH v2 0/3] cpufreq: intel_pstate: trivial improvements Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467048417.8970.80.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=jszhang@marvell.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).