From: Peter Chen <peter.chen@nxp.com>
To: linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Cc: Peter Chen <peter.chen@nxp.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kukjin Kim <kgene@kernel.org>
Subject: [PATCH 7/7] devfreq: exynos-bus: add missing of_node_put after calling of_parse_phandle
Date: Fri, 1 Jul 2016 17:42:01 +0800 [thread overview]
Message-ID: <1467366121-14120-8-git-send-email-peter.chen@nxp.com> (raw)
In-Reply-To: <1467366121-14120-1-git-send-email-peter.chen@nxp.com>
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/devfreq/exynos-bus.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
index 2363d0a..a38b5ec 100644
--- a/drivers/devfreq/exynos-bus.c
+++ b/drivers/devfreq/exynos-bus.c
@@ -383,7 +383,7 @@ err_clk:
static int exynos_bus_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
- struct device_node *np = dev->of_node;
+ struct device_node *np = dev->of_node, node;
struct devfreq_dev_profile *profile;
struct devfreq_simple_ondemand_data *ondemand_data;
struct devfreq_passive_data *passive_data;
@@ -415,10 +415,13 @@ static int exynos_bus_probe(struct platform_device *pdev)
goto err;
}
- if (of_parse_phandle(dev->of_node, "devfreq", 0))
+ node = of_parse_phandle(dev->of_node, "devfreq", 0);
+ if (node) {
+ of_node_put(node);
goto passive;
- else
+ } else {
ret = exynos_bus_parent_parse_of(np, bus);
+ }
if (ret < 0)
goto err;
--
1.9.1
next prev parent reply other threads:[~2016-07-01 9:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1467366121-14120-1-git-send-email-peter.chen@nxp.com>
2016-07-01 9:41 ` [PATCH 1/7] extcon: add missing of_node_put after calling of_parse_phandle Peter Chen
2016-07-02 4:46 ` Chanwoo Choi
2016-07-01 9:41 ` [PATCH 2/7] arm: mach-shmobile: pm-rmobile: " Peter Chen
2016-07-01 12:31 ` Geert Uytterhoeven
2016-07-04 2:10 ` Peter Chen
2016-07-01 9:41 ` [PATCH 3/7] arm: mach-u300: regulator: " Peter Chen
2016-07-01 9:41 ` Peter Chen
2016-07-01 9:41 ` Peter Chen
2016-07-01 9:41 ` Peter Chen
2016-07-01 9:41 ` [PATCH 4/7] bus: arm-cci: " Peter Chen
2016-07-01 10:29 ` Suzuki K Poulose
2016-07-01 10:33 ` Will Deacon
2016-07-04 2:48 ` Peter Chen
2016-07-04 9:19 ` Will Deacon
2016-07-01 9:41 ` [PATCH 5/7] bus: vexpress-config: " Peter Chen
2016-07-11 9:02 ` Liviu Dudau
2016-07-01 9:42 ` [PATCH 6/7] devfreq: " Peter Chen
2016-07-01 9:42 ` Peter Chen [this message]
2016-07-02 4:53 ` [PATCH 7/7] devfreq: exynos-bus: " Chanwoo Choi
[not found] ` <1467366121-14120-4-git-send-email-peter.chen@nxp.com>
2016-07-05 21:24 ` [PATCH 3/7] arm: mach-u300: regulator: " Linus Walleij
[not found] ` <CGME20160701094923epcas1p164cc8773ec44a00dfc506a6192df3409@epcas1p1.samsung.com>
2016-07-06 2:38 ` [PATCH 6/7] devfreq: " MyungJoo Ham
[not found] ` <CGME20160701094927epcas1p43f956ee3465f96e2f9c99b44c0f5b49d@epcas1p4.samsung.com>
2016-07-06 2:47 ` [PATCH 7/7] devfreq: exynos-bus: " MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467366121-14120-8-git-send-email-peter.chen@nxp.com \
--to=peter.chen@nxp.com \
--cc=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).