public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Markus Mayer <mmayer@broadcom.com>
To: Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Cc: Markus Mayer <mmayer@broadcom.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 7/7] power_supply: make use of new strcpytoupper() function
Date: Fri,  8 Jul 2016 15:43:14 -0700	[thread overview]
Message-ID: <1468017794-4818-8-git-send-email-mmayer@broadcom.com> (raw)
In-Reply-To: <1468017794-4818-1-git-send-email-mmayer@broadcom.com>

Call strcpytoupper() rather than walking the string explicitly to
convert it to uppercase.

Signed-off-by: Markus Mayer <mmayer@broadcom.com>
---
 drivers/power/power_supply_sysfs.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
index 80fed98..20fdcc5 100644
--- a/drivers/power/power_supply_sysfs.c
+++ b/drivers/power/power_supply_sysfs.c
@@ -256,19 +256,16 @@ void power_supply_init_attrs(struct device_type *dev_type)
 
 static char *kstruprdup(const char *str, gfp_t gfp)
 {
-	char *ret, *ustr;
+	char *ustr;
 
-	ustr = ret = kmalloc(strlen(str) + 1, gfp);
+	ustr = kmalloc(strlen(str) + 1, gfp);
 
-	if (!ret)
+	if (!ustr)
 		return NULL;
 
-	while (*str)
-		*ustr++ = toupper(*str++);
+	strcpytoupper(ustr, str);
 
-	*ustr = 0;
-
-	return ret;
+	return ustr;
 }
 
 int power_supply_uevent(struct device *dev, struct kobj_uevent_env *env)
-- 
2.7.4


  parent reply	other threads:[~2016-07-08 22:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 22:43 [PATCH v3 0/7] lib: string: add functions to case-convert strings Markus Mayer
     [not found] ` <1468017794-4818-1-git-send-email-mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-07-08 22:43   ` [PATCH v3 1/7] " Markus Mayer
2016-07-09 12:04     ` Luis de Bethencourt
     [not found]       ` <5780E866.8000001-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-07-09 15:30         ` Markus Mayer
     [not found]           ` <CAGt4E5vYzkqgiiQXXjnX7az-KzCVSYthEW5Df03U=Y1qhEJdRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-11 22:46             ` Markus Mayer
     [not found]               ` <CAGt4E5tpw0sa1PQmgJzKbPuzSbFG9_CUWjjO1z93OSc0KkjUXw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-13 17:19                 ` Luis de Bethencourt
     [not found]                   ` <57867813.8010608-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-07-13 22:26                     ` Markus Mayer
     [not found]                       ` <CAGt4E5tRcYQeWdTLvABjpd2WgAPLmdrdEUVK33pS0J3a06wJ5w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-13 22:53                         ` Luis de Bethencourt
     [not found]                           ` <5786C665.6020307-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-07-13 23:04                             ` Markus Mayer
2016-07-08 22:43 ` Markus Mayer [this message]
2016-07-10  3:13 ` [PATCH v3 0/7] " Chris Metcalf
     [not found]   ` <9b88baed-a067-fcfd-d087-66e36f3060d7-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-07-10  4:11     ` Markus Mayer
     [not found]       ` <CAGt4E5t0TGMxiUfV5Mx+EGyAYAmTOCEJe4QxjpjujvZfPwvYuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-13 22:52         ` Markus Mayer
     [not found]           ` <20160713225236.GA30571-opzSsqMRwNylyEujtbL6/5Ym1tgvmhRUMm0uRHvK7Nw@public.gmane.org>
2016-07-20 20:28             ` Markus Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468017794-4818-8-git-send-email-mmayer@broadcom.com \
    --to=mmayer@broadcom.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox