From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Carsten Emde <C.Emde@osadl.org>, Len Brown <lenb@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Linux PM mailing list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: Intel P state driver: clean remnant struct element
Date: Tue, 19 Jul 2016 15:16:23 -0700 [thread overview]
Message-ID: <1468966583.4150.8.camel@linux.intel.com> (raw)
In-Reply-To: <baa442ec-5845-6438-8c03-6793220883e1@osadl.org>
On Tue, 2016-07-19 at 01:19 +0200, Carsten Emde wrote:
> Hi Srinivas,
>
> BTW: when I was working with the Intel P state driver I came across
> a remnant struct element that is no longer needed after the function
> intel_pstate_calc_freq() was retired.
You are right. Can you resend with proper commit message?
Thanks,
Srinivas
> Signed-off-by: Carsten Emde <C.Emde@osadl.org>
>
> Index: linux-4.7.0-rc7+/drivers/cpufreq/intel_pstate.c
> ===================================================================
> --- linux-4.7.0-rc7+.orig/drivers/cpufreq/intel_pstate.c
> +++ linux-4.7.0-rc7+/drivers/cpufreq/intel_pstate.c
> @@ -96,7 +96,6 @@ static inline u64 div_ext_fp(u64 x, u64
> * read from MPERF MSR between last and current
> sample
> * @tsc: Difference of time stamp counter between last
> and
> * current sample
> - * @freq: Effective frequency calculated from
> APERF/MPERF
> * @time: Current time from scheduler
> *
> * This structure is used in the cpudata structure to store
> performance sample
> @@ -108,7 +107,6 @@ struct sample {
> u64 aperf;
> u64 mperf;
> u64 tsc;
> - int freq;
> u64 time;
> };
>
>
prev parent reply other threads:[~2016-07-19 22:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-17 21:51 cpufreq: Intel P state driver: add cycle counter for clock frequency monitoring Carsten Emde
2016-07-18 16:29 ` Srinivas Pandruvada
2016-07-18 21:46 ` Rafael J. Wysocki
2016-07-18 22:06 ` Carsten Emde
2016-07-18 23:19 ` [PATCH] cpufreq: Intel P state driver: clean remnant struct element Carsten Emde
2016-07-19 22:16 ` Srinivas Pandruvada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468966583.4150.8.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=C.Emde@osadl.org \
--cc=lenb@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).