From: Jon Hunter <jonathanh@nvidia.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-pm@vger.kernel.org, Alexander Aring <alex.aring@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>, Eric Anholt <eric@anholt.net>,
Thierry Reding <thierry.reding@gmail.com>,
Kukjin Kim <kgene@kernel.org>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/10] PM / Domains: Add support for removing PM domains
Date: Tue, 16 Aug 2016 10:49:34 +0100 [thread overview]
Message-ID: <1471340976-5379-9-git-send-email-jonathanh@nvidia.com> (raw)
In-Reply-To: <1471340976-5379-1-git-send-email-jonathanh@nvidia.com>
The genpd framework allows users to add PM domains via the pm_genpd_init()
function, however, there is no corresponding function to remove a PM
domain. For most devices this may be fine as the PM domains are never
removed, however, for devices that wish to populate the PM domains from
within a driver, having the ability to remove a PM domain if the probing
of the device fails or the driver is unloaded is necessary.
Add the function pm_genpd_remove() to remove a PM domain by referencing
it's generic_pm_domain structure.
PM domains can only be removed if they are not a parent domain to
another PM domain and have no devices associated with them.
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
drivers/base/power/domain.c | 46 +++++++++++++++++++++++++++++++++++++++++++++
include/linux/pm_domain.h | 5 +++++
2 files changed, 51 insertions(+)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 7ce4608bbbe0..72b973539205 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1356,6 +1356,52 @@ int pm_genpd_init(struct generic_pm_domain *genpd,
}
EXPORT_SYMBOL_GPL(pm_genpd_init);
+/**
+ * pm_genpd_remove - Remove a generic I/O PM domain
+ * @genpd: Pointer to PM domain that is to be removed.
+ *
+ * To remove the PM domain, this function:
+ * - Removes the PM domain as a subdomain to any parent domains,
+ * if it was added.
+ * - Removes the PM domain from the list of registered PM domains.
+ *
+ * The PM domain will only be removed, if it is not a parent to any
+ * other PM domain and has no devices associated with it.
+ */
+int pm_genpd_remove(struct generic_pm_domain *genpd)
+{
+ struct gpd_link *l, *link;
+ int ret = 0;
+
+ if (IS_ERR_OR_NULL(genpd))
+ return -EINVAL;
+
+ mutex_lock(&gpd_list_lock);
+ mutex_lock(&genpd->lock);
+
+ if (!list_empty(&genpd->master_links) || genpd->device_count) {
+ mutex_unlock(&genpd->lock);
+ mutex_unlock(&gpd_list_lock);
+ pr_err("%s: unable to remove %s\n", __func__, genpd->name);
+ return -EBUSY;
+ }
+
+ list_for_each_entry_safe(link, l, &genpd->slave_links, slave_node) {
+ list_del(&link->master_node);
+ list_del(&link->slave_node);
+ kfree(link);
+ }
+
+ list_del(&genpd->gpd_list_node);
+ mutex_unlock(&genpd->lock);
+ cancel_work_sync(&genpd->power_off_work);
+ mutex_unlock(&gpd_list_lock);
+ pr_debug("%s: removed %s\n", __func__, genpd->name);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(pm_genpd_remove);
+
#ifdef CONFIG_PM_GENERIC_DOMAINS_OF
typedef struct generic_pm_domain *(*genpd_xlate_t)(struct of_phandle_args *args,
diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
index f103869db443..fbdc5c4588ef 100644
--- a/include/linux/pm_domain.h
+++ b/include/linux/pm_domain.h
@@ -128,6 +128,7 @@ extern int pm_genpd_remove_subdomain(struct generic_pm_domain *genpd,
struct generic_pm_domain *target);
extern int pm_genpd_init(struct generic_pm_domain *genpd,
struct dev_power_governor *gov, bool is_off);
+extern int pm_genpd_remove(struct generic_pm_domain *genpd);
extern struct dev_power_governor simple_qos_governor;
extern struct dev_power_governor pm_domain_always_on_gov;
@@ -163,6 +164,10 @@ static inline int pm_genpd_init(struct generic_pm_domain *genpd,
{
return -ENOSYS;
}
+static inline int pm_genpd_remove(struct generic_pm_domain *genpd)
+{
+ return -ENOTSUPP;
+}
#endif
static inline int pm_genpd_add_device(struct generic_pm_domain *genpd,
--
2.1.4
next prev parent reply other threads:[~2016-08-16 9:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 9:49 [PATCH 00/10] PM / Domains: Add support for removing PM domains Jon Hunter
2016-08-16 9:49 ` [PATCH 01/10] PM / Domains: Add new helper functions for device-tree Jon Hunter
[not found] ` <1471340976-5379-2-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-09-08 11:34 ` Ulf Hansson
2016-08-16 9:49 ` [PATCH 02/10] ARM: EXYNOS: Remove calls to of_genpd_get_from_provider() Jon Hunter
[not found] ` <1471340976-5379-3-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-08-16 19:26 ` Krzysztof Kozlowski
2016-09-08 11:35 ` Ulf Hansson
2016-08-16 9:49 ` [PATCH 03/10] staging: board: " Jon Hunter
[not found] ` <1471340976-5379-4-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-09-08 11:35 ` Ulf Hansson
2016-08-16 9:49 ` [PATCH 04/10] PM / Domains: Don't expose generic_pm_domain structure to clients Jon Hunter
2016-09-08 11:35 ` Ulf Hansson
2016-08-16 9:49 ` [PATCH 05/10] PM / Domains: Don't expose xlate and provider helper functions Jon Hunter
[not found] ` <1471340976-5379-6-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-09-08 11:36 ` Ulf Hansson
[not found] ` <1471340976-5379-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-08-16 9:49 ` [PATCH 06/10] PM / Domains: Verify the PM domain is present when adding a provider Jon Hunter
2016-09-08 11:39 ` Ulf Hansson
2016-09-09 9:41 ` Jon Hunter
2016-08-26 13:12 ` [PATCH 00/10] PM / Domains: Add support for removing PM domains Jon Hunter
2016-08-16 9:49 ` [PATCH 07/10] PM / Domains: Prepare for adding support to remove " Jon Hunter
2016-09-08 11:41 ` Ulf Hansson
2016-08-16 9:49 ` Jon Hunter [this message]
2016-09-08 11:49 ` [PATCH 08/10] PM / Domains: Add support for removing " Ulf Hansson
[not found] ` <CAPDyKFrVO9wb3ffmxA7HUUDt1_aYxe=aqa1v+xNpdrYiLt_m0A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-09 13:54 ` Jon Hunter
[not found] ` <c8498eca-6934-1cab-31d9-3d8ce4c74897-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-09-09 15:17 ` Jon Hunter
[not found] ` <63871fe6-cda6-2a95-9c09-e4b3ebfa3419-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-09-12 7:21 ` Ulf Hansson
2016-09-12 7:26 ` Jon Hunter
2016-08-16 9:49 ` [PATCH 09/10] PM / Domains: Store the provider in the PM domain structure Jon Hunter
2016-09-08 11:56 ` Ulf Hansson
[not found] ` <CAPDyKFp+93=CrmgLNx1ritm1Dm=eWFJn=vbuzAUb9VmWc4j1fg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-09 13:57 ` Jon Hunter
[not found] ` <73870e28-3600-8a84-7659-55d4a8320a1d-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-09-09 14:25 ` Ulf Hansson
2016-08-16 9:49 ` [PATCH 10/10] PM / Domains: Add support for removing nested PM domains by provider Jon Hunter
2016-09-08 12:30 ` Ulf Hansson
2016-09-09 14:04 ` Jon Hunter
[not found] ` <f31e57aa-52aa-d340-ca2b-73dbdf769035-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-09-09 14:21 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471340976-5379-9-git-send-email-jonathanh@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=alex.aring@gmail.com \
--cc=eric@anholt.net \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).