From: Axel Lin <axel.lin@ingics.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
Lin Huang <hl@rock-chips.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-pm@vger.kernel.org, Axel Lin <axel.lin@ingics.com>
Subject: [PATCH] PM / devfreq: rk3399_dmc: Remove explictly regulator_put call in .remove
Date: Sun, 18 Sep 2016 10:41:05 +0800 [thread overview]
Message-ID: <1474166465-18736-1-git-send-email-axel.lin@ingics.com> (raw)
Current code uses devm_regulator_get() in .probe so a regulator_put() will
be automatically called when unload the module. Remove the explictly
regulator_put() call and then we can also remove rk3399_dmcfreq_remove().
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/devfreq/rk3399_dmc.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
index 54d65f2..e24b73d 100644
--- a/drivers/devfreq/rk3399_dmc.c
+++ b/drivers/devfreq/rk3399_dmc.c
@@ -450,15 +450,6 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
return 0;
}
-static int rk3399_dmcfreq_remove(struct platform_device *pdev)
-{
- struct rk3399_dmcfreq *dmcfreq = platform_get_drvdata(pdev);
-
- regulator_put(dmcfreq->vdd_center);
-
- return 0;
-}
-
static const struct of_device_id rk3399dmc_devfreq_of_match[] = {
{ .compatible = "rockchip,rk3399-dmc" },
{ },
@@ -466,7 +457,6 @@ static const struct of_device_id rk3399dmc_devfreq_of_match[] = {
static struct platform_driver rk3399_dmcfreq_driver = {
.probe = rk3399_dmcfreq_probe,
- .remove = rk3399_dmcfreq_remove,
.driver = {
.name = "rk3399-dmc-freq",
.pm = &rk3399_dmcfreq_pm,
--
2.7.4
next reply other threads:[~2016-09-18 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160918024126epcas1p16b581f05e978e0e2014bb20a47e82aec@epcas1p1.samsung.com>
2016-09-18 2:41 ` Axel Lin [this message]
2016-09-19 0:16 ` [PATCH] PM / devfreq: rk3399_dmc: Remove explictly regulator_put call in .remove Chanwoo Choi
[not found] <CGME20160918024124epcas1p26e45dd69c71bdcded5b336c87f1b246b@epcas1p2.samsung.com>
2016-09-19 7:44 ` MyungJoo Ham
2016-09-19 11:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474166465-18736-1-git-send-email-axel.lin@ingics.com \
--to=axel.lin@ingics.com \
--cc=cw00.choi@samsung.com \
--cc=hl@rock-chips.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).