[PATCH v2 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO

[PATCH v2 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO

[Axel Lin]

This driver uses devm_regmap_init_mmio(), so select REGMAP_MMIO to avoid
build failure.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
---
v2: fix typo in commit log and also add Chanwoo's Ack.
This one is a build fix, I think it should be for v4.8.
 drivers/devfreq/event/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/devfreq/event/Kconfig b/drivers/devfreq/event/Kconfig
index 0fdae86..cd94980 100644
--- a/drivers/devfreq/event/Kconfig
+++ b/drivers/devfreq/event/Kconfig
@@ -17,6 +17,7 @@ config DEVFREQ_EVENT_EXYNOS_NOCP
 	tristate "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver"
 	depends on ARCH_EXYNOS || COMPILE_TEST
 	select PM_OPP
+	select REGMAP_MMIO
 	help
 	  This add the devfreq-event driver for Exynos SoC. It provides NoC
 	  (Network on Chip) Probe counters to measure the bandwidth of AXI bus.
-- 
2.7.4

[PATCH v2 2/2] PM / devfreq: exynos-nocp: Remove redundant code to reset load_count/total_count

[Axel Lin]

This is done by devfreq_event_get_event() so remove the redundant code in
exynos_nocp_get_event().

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
---
v2: only add Chanwoo's Ack.
 drivers/devfreq/event/exynos-nocp.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c
index a584140..49e712a 100644
--- a/drivers/devfreq/event/exynos-nocp.c
+++ b/drivers/devfreq/event/exynos-nocp.c
@@ -176,9 +176,6 @@ static int exynos_nocp_get_event(struct devfreq_event_dev *edev,
 	return 0;
 
 out:
-	edata->load_count = 0;
-	edata->total_count = 0;
-
 	dev_err(nocp->dev, "Failed to read the counter of NoC probe device\n");
 
 	return ret;
-- 
2.7.4

Re: [PATCH v2 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO

[Rafael J. Wysocki]

On Sunday, September 25, 2016 08:13:57 PM Axel Lin wrote:
> This driver uses devm_regmap_init_mmio(), so select REGMAP_MMIO to avoid
> build failure.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> v2: fix typo in commit log and also add Chanwoo's Ack.
> This one is a build fix, I think it should be for v4.8.
>  drivers/devfreq/event/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/devfreq/event/Kconfig b/drivers/devfreq/event/Kconfig
> index 0fdae86..cd94980 100644
> --- a/drivers/devfreq/event/Kconfig
> +++ b/drivers/devfreq/event/Kconfig
> @@ -17,6 +17,7 @@ config DEVFREQ_EVENT_EXYNOS_NOCP
>  	tristate "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver"
>  	depends on ARCH_EXYNOS || COMPILE_TEST
>  	select PM_OPP
> +	select REGMAP_MMIO
>  	help
>  	  This add the devfreq-event driver for Exynos SoC. It provides NoC
>  	  (Network on Chip) Probe counters to measure the bandwidth of AXI bus.
> 

MyungJoo, I can apply this one and the [2/2] directly.  Should I do that?

Thanks,
Rafael

Re: [PATCH v2 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO

[MyungJoo Ham]

On Thu, Sep 29, 2016 at 9:29 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Sunday, September 25, 2016 08:13:57 PM Axel Lin wrote:
>> This driver uses devm_regmap_init_mmio(), so select REGMAP_MMIO to avoid
>> build failure.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> v2: fix typo in commit log and also add Chanwoo's Ack.
>> This one is a build fix, I think it should be for v4.8.
>>  drivers/devfreq/event/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/devfreq/event/Kconfig b/drivers/devfreq/event/Kconfig
>> index 0fdae86..cd94980 100644
>> --- a/drivers/devfreq/event/Kconfig
>> +++ b/drivers/devfreq/event/Kconfig
>> @@ -17,6 +17,7 @@ config DEVFREQ_EVENT_EXYNOS_NOCP
>>       tristate "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver"
>>       depends on ARCH_EXYNOS || COMPILE_TEST
>>       select PM_OPP
>> +     select REGMAP_MMIO
>>       help
>>         This add the devfreq-event driver for Exynos SoC. It provides NoC
>>         (Network on Chip) Probe counters to measure the bandwidth of AXI bus.
>>
>
> MyungJoo, I can apply this one and the [2/2] directly.  Should I do that?
>
> Thanks,
> Rafael


Yes, sure. Those two fixes look good. Thanks.




Cheers,
MyungJoo

>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
MyungJoo Ham, Ph.D.
Frontier CS Lab, S/W Center, Samsung Electronics

Re: [PATCH v2 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO

[Rafael J. Wysocki]

On Friday, September 30, 2016 10:46:04 PM MyungJoo Ham wrote:
> On Thu, Sep 29, 2016 at 9:29 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Sunday, September 25, 2016 08:13:57 PM Axel Lin wrote:
> >> This driver uses devm_regmap_init_mmio(), so select REGMAP_MMIO to avoid
> >> build failure.
> >>
> >> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> >> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
> >> ---
> >> v2: fix typo in commit log and also add Chanwoo's Ack.
> >> This one is a build fix, I think it should be for v4.8.
> >>  drivers/devfreq/event/Kconfig | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/devfreq/event/Kconfig b/drivers/devfreq/event/Kconfig
> >> index 0fdae86..cd94980 100644
> >> --- a/drivers/devfreq/event/Kconfig
> >> +++ b/drivers/devfreq/event/Kconfig
> >> @@ -17,6 +17,7 @@ config DEVFREQ_EVENT_EXYNOS_NOCP
> >>       tristate "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver"
> >>       depends on ARCH_EXYNOS || COMPILE_TEST
> >>       select PM_OPP
> >> +     select REGMAP_MMIO
> >>       help
> >>         This add the devfreq-event driver for Exynos SoC. It provides NoC
> >>         (Network on Chip) Probe counters to measure the bandwidth of AXI bus.
> >>
> >
> > MyungJoo, I can apply this one and the [2/2] directly.  Should I do that?
> >
> > Thanks,
> > Rafael
> 
> 
> Yes, sure. Those two fixes look good. Thanks.

OK, applied.

Thanks,
Rafael