From: Axel Lin <axel.lin@ingics.com>
To: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Axel Lin <axel.lin@ingics.com>
Subject: [PATCH] PM / devfreq: Add proper locking around list_del()
Date: Wed, 28 Sep 2016 17:17:56 +0800 [thread overview]
Message-ID: <1475054276-29528-1-git-send-email-axel.lin@ingics.com> (raw)
Use devfreq_list_lock around list_del() to prevent list corruption.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/devfreq/devfreq.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 478006b..70369b0 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -604,7 +604,10 @@ struct devfreq *devfreq_add_device(struct device *dev,
return devfreq;
err_init:
+ mutex_lock(&devfreq_list_lock);
list_del(&devfreq->node);
+ mutex_unlock(&devfreq_list_lock);
+
device_unregister(&devfreq->dev);
err_out:
return ERR_PTR(err);
--
2.7.4
next reply other threads:[~2016-09-28 9:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 9:17 Axel Lin [this message]
[not found] <CGME20160928091837epcas1p2e3a1fbf609e57b789c503ce4c1799dd1@epcas1p2.samsung.com>
2016-09-29 2:02 ` [PATCH] PM / devfreq: Add proper locking around list_del() MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475054276-29528-1-git-send-email-axel.lin@ingics.com \
--to=axel.lin@ingics.com \
--cc=cw00.choi@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).