* [PATCH v2 0/2] power_supply: add new POWER_SUPPLY_PROP_POLL_INTERVAL property @ 2016-09-28 19:55 Matt Ranostay 2016-09-28 19:55 ` [PATCH v2 1/2] power: power_supply: add new property POWER_SUPPLY_PROP_POLL_INTERVAL Matt Ranostay 2016-09-28 19:55 ` [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Matt Ranostay 0 siblings, 2 replies; 4+ messages in thread From: Matt Ranostay @ 2016-09-28 19:55 UTC (permalink / raw) To: Sebastian Reichel; +Cc: linux-pm, linux-kernel, Matt Ranostay Add power supply class POWER_SUPPLY_PROP_POLL_INTERVAL to allow dynamic device statistic updating interval. Changes from v1: * Fixed milliseconds typo in commit message * Fixed file paths to drivers/power/supply * Don't update if settings are the same condition Matt Ranostay (2): power: power_supply: add new property POWER_SUPPLY_PROP_POLL_INTERVAL power: bq27xxx_battery: add poll interval property query Documentation/power/power_supply_class.txt | 1 + drivers/power/supply/bq27xxx_battery.c | 40 ++++++++++++++++++++++++++++++ drivers/power/supply/power_supply_sysfs.c | 1 + include/linux/power_supply.h | 1 + 4 files changed, 43 insertions(+) -- 2.7.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/2] power: power_supply: add new property POWER_SUPPLY_PROP_POLL_INTERVAL 2016-09-28 19:55 [PATCH v2 0/2] power_supply: add new POWER_SUPPLY_PROP_POLL_INTERVAL property Matt Ranostay @ 2016-09-28 19:55 ` Matt Ranostay 2016-09-28 19:55 ` [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Matt Ranostay 1 sibling, 0 replies; 4+ messages in thread From: Matt Ranostay @ 2016-09-28 19:55 UTC (permalink / raw) To: Sebastian Reichel; +Cc: linux-pm, linux-kernel, Matt Ranostay, Tony Lindgren Add new POWER_SUPPLY_PROP_POLL_INTERVAL property to display/set the update interval in seconds of the device. Cc: Sebastian Reichel <sre@kernel.org> Cc: Tony Lindgren <tony@atomide.com Signed-off-by: Matt Ranostay <matt@ranostay.consulting> --- Documentation/power/power_supply_class.txt | 1 + drivers/power/supply/power_supply_sysfs.c | 1 + include/linux/power_supply.h | 1 + 3 files changed, 3 insertions(+) diff --git a/Documentation/power/power_supply_class.txt b/Documentation/power/power_supply_class.txt index 0c72588bd967..df9b315fe55c 100644 --- a/Documentation/power/power_supply_class.txt +++ b/Documentation/power/power_supply_class.txt @@ -158,6 +158,7 @@ while battery powers a load) TIME_TO_FULL - seconds left for battery to be considered full (i.e. while battery is charging) +POLL_INTERVAL - seconds between queries to retrieve stats from hardware Battery <-> external power supply interaction ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c index bcde8d13476a..580fd4bfe5f5 100644 --- a/drivers/power/supply/power_supply_sysfs.c +++ b/drivers/power/supply/power_supply_sysfs.c @@ -198,6 +198,7 @@ static struct device_attribute power_supply_attrs[] = { POWER_SUPPLY_ATTR(scope), POWER_SUPPLY_ATTR(charge_term_current), POWER_SUPPLY_ATTR(calibrate), + POWER_SUPPLY_ATTR(poll_interval), /* Properties of type `const char *' */ POWER_SUPPLY_ATTR(model_name), POWER_SUPPLY_ATTR(manufacturer), diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h index 3965503315ef..8b4cfe950d3b 100644 --- a/include/linux/power_supply.h +++ b/include/linux/power_supply.h @@ -148,6 +148,7 @@ enum power_supply_property { POWER_SUPPLY_PROP_SCOPE, POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT, POWER_SUPPLY_PROP_CALIBRATE, + POWER_SUPPLY_PROP_POLL_INTERVAL, /* in seconds! */ /* Properties of type `const char *' */ POWER_SUPPLY_PROP_MODEL_NAME, POWER_SUPPLY_PROP_MANUFACTURER, -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query 2016-09-28 19:55 [PATCH v2 0/2] power_supply: add new POWER_SUPPLY_PROP_POLL_INTERVAL property Matt Ranostay 2016-09-28 19:55 ` [PATCH v2 1/2] power: power_supply: add new property POWER_SUPPLY_PROP_POLL_INTERVAL Matt Ranostay @ 2016-09-28 19:55 ` Matt Ranostay 2016-10-24 19:58 ` Matt Ranostay 1 sibling, 1 reply; 4+ messages in thread From: Matt Ranostay @ 2016-09-28 19:55 UTC (permalink / raw) To: Sebastian Reichel; +Cc: linux-pm, linux-kernel, Matt Ranostay, Tony Lindgren Add POWER_SUPPLY_PROP_POLL_INTERVAL property to query and set the polling interval of the fuel gauge. Cc: Sebastian Reichel <sre@kernel.org> Cc: Tony Lindgren <tony@atomide.com Signed-off-by: Matt Ranostay <matt@ranostay.consulting> --- drivers/power/supply/bq27xxx_battery.c | 40 ++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c index 3b0dbc689d72..d18802ca3327 100644 --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -262,6 +262,7 @@ static enum power_supply_property bq27000_battery_props[] = { POWER_SUPPLY_PROP_POWER_AVG, POWER_SUPPLY_PROP_HEALTH, POWER_SUPPLY_PROP_MANUFACTURER, + POWER_SUPPLY_PROP_POLL_INTERVAL, }; static enum power_supply_property bq27010_battery_props[] = { @@ -282,6 +283,7 @@ static enum power_supply_property bq27010_battery_props[] = { POWER_SUPPLY_PROP_CYCLE_COUNT, POWER_SUPPLY_PROP_HEALTH, POWER_SUPPLY_PROP_MANUFACTURER, + POWER_SUPPLY_PROP_POLL_INTERVAL, }; static enum power_supply_property bq27500_battery_props[] = { @@ -300,6 +302,7 @@ static enum power_supply_property bq27500_battery_props[] = { POWER_SUPPLY_PROP_CYCLE_COUNT, POWER_SUPPLY_PROP_HEALTH, POWER_SUPPLY_PROP_MANUFACTURER, + POWER_SUPPLY_PROP_POLL_INTERVAL, }; static enum power_supply_property bq27530_battery_props[] = { @@ -318,6 +321,7 @@ static enum power_supply_property bq27530_battery_props[] = { POWER_SUPPLY_PROP_HEALTH, POWER_SUPPLY_PROP_CYCLE_COUNT, POWER_SUPPLY_PROP_MANUFACTURER, + POWER_SUPPLY_PROP_POLL_INTERVAL, }; static enum power_supply_property bq27541_battery_props[] = { @@ -337,6 +341,7 @@ static enum power_supply_property bq27541_battery_props[] = { POWER_SUPPLY_PROP_POWER_AVG, POWER_SUPPLY_PROP_HEALTH, POWER_SUPPLY_PROP_MANUFACTURER, + POWER_SUPPLY_PROP_POLL_INTERVAL, }; static enum power_supply_property bq27545_battery_props[] = { @@ -355,6 +360,7 @@ static enum power_supply_property bq27545_battery_props[] = { POWER_SUPPLY_PROP_CYCLE_COUNT, POWER_SUPPLY_PROP_POWER_AVG, POWER_SUPPLY_PROP_MANUFACTURER, + POWER_SUPPLY_PROP_POLL_INTERVAL, }; static enum power_supply_property bq27421_battery_props[] = { @@ -370,6 +376,7 @@ static enum power_supply_property bq27421_battery_props[] = { POWER_SUPPLY_PROP_CHARGE_NOW, POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN, POWER_SUPPLY_PROP_MANUFACTURER, + POWER_SUPPLY_PROP_POLL_INTERVAL, }; #define BQ27XXX_PROP(_id, _prop) \ @@ -955,6 +962,9 @@ static int bq27xxx_battery_get_property(struct power_supply *psy, case POWER_SUPPLY_PROP_MANUFACTURER: val->strval = BQ27XXX_MANUFACTURER; break; + case POWER_SUPPLY_PROP_POLL_INTERVAL: + val->intval = poll_interval; + break; default: return -EINVAL; } @@ -962,6 +972,34 @@ static int bq27xxx_battery_get_property(struct power_supply *psy, return ret; } +static int bq27xxx_battery_set_property(struct power_supply *psy, + enum power_supply_property psp, + const union power_supply_propval *val) +{ + struct bq27xxx_device_info *di = power_supply_get_drvdata(psy); + + if (psp != POWER_SUPPLY_PROP_POLL_INTERVAL) + return -EINVAL; + + if (poll_interval == val->intval) + return 0; + + poll_interval = val->intval; + cancel_delayed_work_sync(&di->work); + schedule_delayed_work(&di->work, 0); + + return 0; +} + +static int bq27xxx_property_is_writeable(struct power_supply *psy, + enum power_supply_property psp) +{ + if (psp == POWER_SUPPLY_PROP_POLL_INTERVAL) + return 1; + + return 0; +} + static void bq27xxx_external_power_changed(struct power_supply *psy) { struct bq27xxx_device_info *di = power_supply_get_drvdata(psy); @@ -988,6 +1026,8 @@ int bq27xxx_battery_setup(struct bq27xxx_device_info *di) psy_desc->properties = bq27xxx_battery_props[di->chip].props; psy_desc->num_properties = bq27xxx_battery_props[di->chip].size; psy_desc->get_property = bq27xxx_battery_get_property; + psy_desc->set_property = bq27xxx_battery_set_property; + psy_desc->property_is_writeable = bq27xxx_property_is_writeable; psy_desc->external_power_changed = bq27xxx_external_power_changed; di->bat = power_supply_register_no_ws(di->dev, psy_desc, &psy_cfg); -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query 2016-09-28 19:55 ` [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Matt Ranostay @ 2016-10-24 19:58 ` Matt Ranostay 0 siblings, 0 replies; 4+ messages in thread From: Matt Ranostay @ 2016-10-24 19:58 UTC (permalink / raw) To: Sebastian Reichel, Pavel Machek Cc: linux-pm, linux-kernel@vger.kernel.org, Matt Ranostay, Tony Lindgren Pavel + Sebastian this is the patchset that need I some input on :) Thanks, Matt On Wed, Sep 28, 2016 at 12:55 PM, Matt Ranostay <mranostay@gmail.com> wrote: > Add POWER_SUPPLY_PROP_POLL_INTERVAL property to query and set the > polling interval of the fuel gauge. > > Cc: Sebastian Reichel <sre@kernel.org> > Cc: Tony Lindgren <tony@atomide.com > Signed-off-by: Matt Ranostay <matt@ranostay.consulting> > --- > drivers/power/supply/bq27xxx_battery.c | 40 ++++++++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c > index 3b0dbc689d72..d18802ca3327 100644 > --- a/drivers/power/supply/bq27xxx_battery.c > +++ b/drivers/power/supply/bq27xxx_battery.c > @@ -262,6 +262,7 @@ static enum power_supply_property bq27000_battery_props[] = { > POWER_SUPPLY_PROP_POWER_AVG, > POWER_SUPPLY_PROP_HEALTH, > POWER_SUPPLY_PROP_MANUFACTURER, > + POWER_SUPPLY_PROP_POLL_INTERVAL, > }; > > static enum power_supply_property bq27010_battery_props[] = { > @@ -282,6 +283,7 @@ static enum power_supply_property bq27010_battery_props[] = { > POWER_SUPPLY_PROP_CYCLE_COUNT, > POWER_SUPPLY_PROP_HEALTH, > POWER_SUPPLY_PROP_MANUFACTURER, > + POWER_SUPPLY_PROP_POLL_INTERVAL, > }; > > static enum power_supply_property bq27500_battery_props[] = { > @@ -300,6 +302,7 @@ static enum power_supply_property bq27500_battery_props[] = { > POWER_SUPPLY_PROP_CYCLE_COUNT, > POWER_SUPPLY_PROP_HEALTH, > POWER_SUPPLY_PROP_MANUFACTURER, > + POWER_SUPPLY_PROP_POLL_INTERVAL, > }; > > static enum power_supply_property bq27530_battery_props[] = { > @@ -318,6 +321,7 @@ static enum power_supply_property bq27530_battery_props[] = { > POWER_SUPPLY_PROP_HEALTH, > POWER_SUPPLY_PROP_CYCLE_COUNT, > POWER_SUPPLY_PROP_MANUFACTURER, > + POWER_SUPPLY_PROP_POLL_INTERVAL, > }; > > static enum power_supply_property bq27541_battery_props[] = { > @@ -337,6 +341,7 @@ static enum power_supply_property bq27541_battery_props[] = { > POWER_SUPPLY_PROP_POWER_AVG, > POWER_SUPPLY_PROP_HEALTH, > POWER_SUPPLY_PROP_MANUFACTURER, > + POWER_SUPPLY_PROP_POLL_INTERVAL, > }; > > static enum power_supply_property bq27545_battery_props[] = { > @@ -355,6 +360,7 @@ static enum power_supply_property bq27545_battery_props[] = { > POWER_SUPPLY_PROP_CYCLE_COUNT, > POWER_SUPPLY_PROP_POWER_AVG, > POWER_SUPPLY_PROP_MANUFACTURER, > + POWER_SUPPLY_PROP_POLL_INTERVAL, > }; > > static enum power_supply_property bq27421_battery_props[] = { > @@ -370,6 +376,7 @@ static enum power_supply_property bq27421_battery_props[] = { > POWER_SUPPLY_PROP_CHARGE_NOW, > POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN, > POWER_SUPPLY_PROP_MANUFACTURER, > + POWER_SUPPLY_PROP_POLL_INTERVAL, > }; > > #define BQ27XXX_PROP(_id, _prop) \ > @@ -955,6 +962,9 @@ static int bq27xxx_battery_get_property(struct power_supply *psy, > case POWER_SUPPLY_PROP_MANUFACTURER: > val->strval = BQ27XXX_MANUFACTURER; > break; > + case POWER_SUPPLY_PROP_POLL_INTERVAL: > + val->intval = poll_interval; > + break; > default: > return -EINVAL; > } > @@ -962,6 +972,34 @@ static int bq27xxx_battery_get_property(struct power_supply *psy, > return ret; > } > > +static int bq27xxx_battery_set_property(struct power_supply *psy, > + enum power_supply_property psp, > + const union power_supply_propval *val) > +{ > + struct bq27xxx_device_info *di = power_supply_get_drvdata(psy); > + > + if (psp != POWER_SUPPLY_PROP_POLL_INTERVAL) > + return -EINVAL; > + > + if (poll_interval == val->intval) > + return 0; > + > + poll_interval = val->intval; > + cancel_delayed_work_sync(&di->work); > + schedule_delayed_work(&di->work, 0); > + > + return 0; > +} > + > +static int bq27xxx_property_is_writeable(struct power_supply *psy, > + enum power_supply_property psp) > +{ > + if (psp == POWER_SUPPLY_PROP_POLL_INTERVAL) > + return 1; > + > + return 0; > +} > + > static void bq27xxx_external_power_changed(struct power_supply *psy) > { > struct bq27xxx_device_info *di = power_supply_get_drvdata(psy); > @@ -988,6 +1026,8 @@ int bq27xxx_battery_setup(struct bq27xxx_device_info *di) > psy_desc->properties = bq27xxx_battery_props[di->chip].props; > psy_desc->num_properties = bq27xxx_battery_props[di->chip].size; > psy_desc->get_property = bq27xxx_battery_get_property; > + psy_desc->set_property = bq27xxx_battery_set_property; > + psy_desc->property_is_writeable = bq27xxx_property_is_writeable; > psy_desc->external_power_changed = bq27xxx_external_power_changed; > > di->bat = power_supply_register_no_ws(di->dev, psy_desc, &psy_cfg); > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-24 19:58 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-09-28 19:55 [PATCH v2 0/2] power_supply: add new POWER_SUPPLY_PROP_POLL_INTERVAL property Matt Ranostay 2016-09-28 19:55 ` [PATCH v2 1/2] power: power_supply: add new property POWER_SUPPLY_PROP_POLL_INTERVAL Matt Ranostay 2016-09-28 19:55 ` [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Matt Ranostay 2016-10-24 19:58 ` Matt Ranostay
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).