* [PATCH] power: bq27xxx_battery: don't update poll_interval param if same
@ 2016-10-01 4:45 Matt Ranostay
2016-10-19 3:00 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Matt Ranostay @ 2016-10-01 4:45 UTC (permalink / raw)
To: linux-pm, linux-kernel; +Cc: Matt Ranostay, Tony Lindgren, Sebastian Reichel
To avoid canceling the delayed workqueue needlessly, and scheduling an
immediate polling. Check if the new poll_interval value is different
than the previous setting.
Cc: Tony Lindgren <tony@atomide.com>
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Matt Ranostay <matt@ranostay.consulting>
---
drivers/power/supply/bq27xxx_battery.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
index d18802ca3327..e01cea9a395a 100644
--- a/drivers/power/supply/bq27xxx_battery.c
+++ b/drivers/power/supply/bq27xxx_battery.c
@@ -404,10 +404,11 @@ static LIST_HEAD(bq27xxx_battery_devices);
static int poll_interval_param_set(const char *val, const struct kernel_param *kp)
{
struct bq27xxx_device_info *di;
+ unsigned int prev_val = *(unsigned int *) kp->arg;
int ret;
ret = param_set_uint(val, kp);
- if (ret < 0)
+ if (ret < 0 || prev_val == *(unsigned int *) kp->arg)
return ret;
mutex_lock(&bq27xxx_list_lock);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] power: bq27xxx_battery: don't update poll_interval param if same
2016-10-01 4:45 [PATCH] power: bq27xxx_battery: don't update poll_interval param if same Matt Ranostay
@ 2016-10-19 3:00 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2016-10-19 3:00 UTC (permalink / raw)
To: Matt Ranostay; +Cc: linux-pm, linux-kernel, Matt Ranostay, Tony Lindgren
[-- Attachment #1: Type: text/plain, Size: 439 bytes --]
Hi,
On Fri, Sep 30, 2016 at 09:45:30PM -0700, Matt Ranostay wrote:
> To avoid canceling the delayed workqueue needlessly, and scheduling an
> immediate polling. Check if the new poll_interval value is different
> than the previous setting.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Matt Ranostay <matt@ranostay.consulting>
Thanks, queued to for-next.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-19 3:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-01 4:45 [PATCH] power: bq27xxx_battery: don't update poll_interval param if same Matt Ranostay
2016-10-19 3:00 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).