Re: [PATCH] thermal: intel_pch_thermal: Support skylake PCH 100 series thermal

["Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>]

On Tue, 2016-10-18 at 06:44 +0900, OGAWA Hirofumi wrote:
> Using registers are compatible with current driver.
This description is not enough. Without going through the whole code, I
was not able to find out what this patch is doing.

Basically you want to tie the themal_zone name and device operations to
a board, rather than to PCI devices ids. In this way multiple PCI ids
for the same board can be accounted for.

Also need to consider another patch sent to mailing list for supporting
Haswell PCH.

One comment below in the code.

[...]
 
>  static struct pci_device_id intel_pch_thermal_id[] = {
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_WPT) },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_SKL) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_WPT),
> +	  .driver_data = board_wpt, },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_SKL),
> +	  .driver_data = board_skl, },
> +	/* skylake PCH 100 series */
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xa131),
Change a131 to a define (PCH_THERMAL_DID_SKL_H)

Thanks,
Srinivas